[BUGFIX] Filter Solr connections based on language fallback settings#4514
Open
siwa-ddiesenreither wants to merge 2 commits into
Open
[BUGFIX] Filter Solr connections based on language fallback settings#4514siwa-ddiesenreither wants to merge 2 commits into
siwa-ddiesenreither wants to merge 2 commits into
Conversation
dkd-kaehm
requested changes
Jan 20, 2026
Collaborator
dkd-kaehm
left a comment
dkd-kaehm
left a comment
There was a problem hiding this comment.
Thanks for fixing that issue.
Please fix the static-analysis issues:
https://github.com/TYPO3-Solr/ext-solr/actions/runs/21178675347/job/60916087419?pr=4514#step:10:69
Author
|
@dkd-kaehm did i miss anything else here? |
Collaborator
|
@siwa-ddiesenreither |
siwa-ddiesenreither
force-pushed
the
bugfix/filter-solr-connection-by-page
branch
from
7ac3110 to
8c606f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this pr does
Added a check if then solrConnections language has only 0 as fallback language - if so and the default language is hidden also hide this language.
How to test
See description of issue.
Fixes: #4513