[TASK] Allow other views than FluidViewAdapter in search controller#4522
Open
eliashaeussler wants to merge 3 commits into
Open
[TASK] Allow other views than FluidViewAdapter in search controller#4522eliashaeussler wants to merge 3 commits into
eliashaeussler wants to merge 3 commits into
Conversation
eliashaeussler
force-pushed
the
task/view
branch
from
2024f05 to
6eb4a48
Compare
Collaborator
|
Please resolve conflicts by rebasing. |
IngoMueller
force-pushed
the
task/view
branch
2 times, most recently
from
68c0991 to
141be68
Compare
# Conflicts: # Classes/Controller/SearchController.php
|
@dkd-kaehm Resolving is done |
dkd-kaehm
force-pushed
the
main
branch
4 times, most recently
from
0c90549 to
365cf5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this pr does
This PR modifies
\ApacheSolrForTypo3\Solr\Controller\SearchController::initializeViewto allow other template views thanFluidViewAdapterfor template rendering. This effectively opens EXT:solr plugin rendering for other templating engines or custom view implementations. Since the provided view initializations are exclusively written forFluidViewAdapterinstances, the method returns early if other instances are passed.How to test
Testing is hard, because it requires a lot of custom components, e.g. a custom
ViewFactoryand a customViewimplementation.Fixes: #4521