[TASK] Refactor FrontendAwareEnvironment and adjust tests#4589
Open
froemken wants to merge 2 commits into
Open
[TASK] Refactor FrontendAwareEnvironment and adjust tests#4589froemken wants to merge 2 commits into
froemken wants to merge 2 commits into
Conversation
dkd-kaehm
force-pushed
the
refactorFrontendAwareEnvironment
branch
from
4ec3d6e to
970d6e7
Compare
froemken
commented
May 2, 2026
| * | ||
| * Convenience method to extract the page ID from the PageInformation attribute. | ||
| */ | ||
| public function getPageIdFromRequest(ServerRequest $request): int |
Contributor
Author
There was a problem hiding this comment.
Sure this is not needed anymore? It's not part of the commit message and in this patch this method was only found ones. I don't see from where it is/was called.
Collaborator
There was a problem hiding this comment.
Please decide.
If you ask me: I did not change anything on that branch.
- Refactor `FrontendAwareEnvironment` to use constructor property promotion. - Remove unused `SingletonInterface` implementation and related usages. - Replace `GeneralUtility::makeInstance` calls with dependency injection. - Add `frontend_simulation` service configuration in `Services.yaml`. - Simplify `TsfeTest` by using an explicitly instantiated `FrontendAwareEnvironment`.
- Update Services.yaml to set `public: true` for `FrontendSimulation`.
dkd-kaehm
force-pushed
the
refactorFrontendAwareEnvironment
branch
from
970d6e7 to
4dce8e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FrontendAwareEnvironmentto use constructor property promotion.SingletonInterfaceimplementation and related usages.GeneralUtility::makeInstancecalls with dependency injection.frontend_simulationservice configuration inServices.yaml.TsfeTestby using an explicitly instantiatedFrontendAwareEnvironment.