fix: propagate error instead of panicking on non-UTF-8 reference name in checkout#4481
Open
kuishou68 wants to merge 1 commit into
Open
fix: propagate error instead of panicking on non-UTF-8 reference name in checkout#4481kuishou68 wants to merge 1 commit into
kuishou68 wants to merge 1 commit into
Conversation
… in checkout When `reference.name()` returns `None` (i.e., the ref name is not valid UTF-8), calling `.unwrap()` causes a panic. Since the enclosing function returns `anyhow::Result`, convert the `Option` to a `Result` with `ok_or_else` so the error is propagated to the caller instead. Signed-off-by: Cocoon-Break <54054995+kuishou68@users.noreply.github.com>
|
Replacing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
crates/tabby-index/src/code/repository.rs, the call toreference.name().unwrap()can panic at runtime.reference.name()returnsOption<&str>, which isNonewhen the reference name contains non-UTF-8 bytes. Sincegit2exposes raw bytes for ref names, this is a valid (if rare) code path that causes an unhandled panic.Fix
Replace
.unwrap()with.ok_or_else()to convert theOptioninto aResultand propagate the error throughanyhow, which the function already returns:This avoids the panic and allows callers to handle the error gracefully.
Signed-off-by: Cocoon-Break 54054995+kuishou68@users.noreply.github.com