-
-
Notifications
You must be signed in to change notification settings - Fork 143
Expand file tree
/
Copy pathTableRowsMutationTests.swift
More file actions
132 lines (113 loc) · 4.7 KB
/
TableRowsMutationTests.swift
File metadata and controls
132 lines (113 loc) · 4.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
//
// TableRowsMutationTests.swift
// TableProTests
//
// Regression tests for the setActiveTableRows / switchActiveResultSet
// dispatch path. Without applyFullReplace, the data grid coordinator's
// RowID-keyed display cache survives table switches and returns stale
// cell values for matching RowIDs across tables.
//
import AppKit
import Foundation
import Testing
@testable import TablePro
@MainActor
private final class FakeTableViewCoordinator: TableViewCoordinating {
var fullReplaceCount = 0
var insertedCount = 0
var removedCount = 0
var deltaCount = 0
var invalidateCount = 0
var commitEditCount = 0
var beginEditingCalls: [(row: Int, column: Int)] = []
func applyInsertedRows(_ indices: IndexSet) { insertedCount += 1 }
func applyRemovedRows(_ indices: IndexSet) { removedCount += 1 }
func applyFullReplace() { fullReplaceCount += 1 }
func applyDelta(_ delta: Delta) { deltaCount += 1 }
func invalidateCachesForUndoRedo() { invalidateCount += 1 }
func commitActiveCellEdit() { commitEditCount += 1 }
func beginEditing(displayRow: Int, column: Int) {
beginEditingCalls.append((row: displayRow, column: column))
}
var refreshFKCount = 0
var scrollToTopCount = 0
func refreshForeignKeyColumns() { refreshFKCount += 1 }
func scrollToTop() { scrollToTopCount += 1 }
}
@Suite("setActiveTableRows dispatch")
@MainActor
struct TableRowsMutationTests {
private struct Fixture {
let coordinator: MainContentCoordinator
let tabManager: QueryTabManager
let delegate: DataTabGridDelegate
let fake: FakeTableViewCoordinator
}
private func makeFixture() -> Fixture {
let tabManager = QueryTabManager()
let coordinator = MainContentCoordinator(
connection: TestFixtures.makeConnection(),
tabManager: tabManager,
changeManager: DataChangeManager(),
filterStateManager: FilterStateManager(),
columnVisibilityManager: ColumnVisibilityManager(),
toolbarState: ConnectionToolbarState()
)
let delegate = DataTabGridDelegate()
let fake = FakeTableViewCoordinator()
delegate.tableViewCoordinator = fake
coordinator.dataTabDelegate = delegate
return Fixture(coordinator: coordinator, tabManager: tabManager, delegate: delegate, fake: fake)
}
private func makeTableRows(rowCount: Int) -> TableRows {
let columns = ["id", "name"]
let rows = (0..<rowCount).map { ["\($0)", "row\($0)"] }
return TableRows.from(
queryRows: rows,
columns: columns,
columnTypes: Array(repeating: .text(rawType: nil), count: columns.count)
)
}
@Test("setActiveTableRows on the active tab dispatches applyFullReplace")
func dispatchesOnActiveTab() {
let f = makeFixture()
f.tabManager.addTableTab(tableName: "users")
let activeTabId = f.tabManager.tabs[0].id
f.coordinator.setActiveTableRows(makeTableRows(rowCount: 3), for: activeTabId)
#expect(f.fake.fullReplaceCount == 1)
}
@Test("setActiveTableRows on a background tab does not dispatch")
func skipsOnBackgroundTab() {
let f = makeFixture()
f.tabManager.addTableTab(tableName: "users")
let backgroundTabId = f.tabManager.tabs[0].id
f.tabManager.addTableTab(tableName: "orders")
f.coordinator.setActiveTableRows(makeTableRows(rowCount: 5), for: backgroundTabId)
#expect(f.fake.fullReplaceCount == 0)
}
@Test("repeated setActiveTableRows dispatches once per call")
func dispatchesOncePerCall() {
let f = makeFixture()
f.tabManager.addTableTab(tableName: "users")
let activeTabId = f.tabManager.tabs[0].id
f.coordinator.setActiveTableRows(TableRows(), for: activeTabId)
f.coordinator.setActiveTableRows(makeTableRows(rowCount: 3), for: activeTabId)
#expect(f.fake.fullReplaceCount == 2)
}
@Test("setActiveTableRows is a no-op when delegate is unwired")
func unwiredDelegateIsNoOp() {
let tabManager = QueryTabManager()
let coordinator = MainContentCoordinator(
connection: TestFixtures.makeConnection(),
tabManager: tabManager,
changeManager: DataChangeManager(),
filterStateManager: FilterStateManager(),
columnVisibilityManager: ColumnVisibilityManager(),
toolbarState: ConnectionToolbarState()
)
tabManager.addTableTab(tableName: "users")
let tabId = tabManager.tabs[0].id
coordinator.setActiveTableRows(makeTableRows(rowCount: 2), for: tabId)
#expect(coordinator.tableRowsStore.tableRows(for: tabId).count == 2)
}
}