-
-
Notifications
You must be signed in to change notification settings - Fork 299
Expand file tree
/
Copy pathSaveCompletionTests.swift
More file actions
295 lines (231 loc) · 10.2 KB
/
Copy pathSaveCompletionTests.swift
File metadata and controls
295 lines (231 loc) · 10.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
//
// SaveCompletionTests.swift
// TableProTests
//
// Tests for the save completion paths in MainContentCoordinator.saveChanges(),
// verifying that every exit path produces the correct outcome (error message
// or silent success) and does not leave the coordinator in an inconsistent state.
//
import Foundation
@testable import TablePro
import Testing
@MainActor @Suite("Save Completion")
struct SaveCompletionTests {
// MARK: - Helpers
private func makeCoordinator(
safeModeLevel: SafeModeLevel = .silent,
type: DatabaseType = .mysql
) -> (MainContentCoordinator, QueryTabManager, DataChangeManager) {
var conn = TestFixtures.makeConnection(type: type)
conn.safeModeLevel = safeModeLevel
let state = SessionStateFactory.create(connection: conn, payload: nil)
state.coordinator.tableOperationOverride = FakeTableOperationProvider()
return (state.coordinator, state.tabManager, state.changeManager)
}
// MARK: - No Changes
@Test("saveChanges with no changes returns immediately without error")
func noChanges_returnsWithoutError() {
let (coordinator, tabManager, _) = makeCoordinator()
tabManager.addTab(databaseName: "testdb")
var truncates: Set<String> = []
var deletes: Set<String> = []
var options: [String: TableOperationOptions] = [:]
coordinator.saveChanges(
pendingTruncates: &truncates,
pendingDeletes: &deletes,
tableOperationOptions: &options
)
#expect(tabManager.tabs.first?.execution.errorMessage == nil)
}
// MARK: - Read-Only Connection
@Test("saveChanges on read-only connection sets error message")
func readOnly_setsErrorMessage() {
let (coordinator, tabManager, changeManager) = makeCoordinator(safeModeLevel: .readOnly)
tabManager.addTab(databaseName: "testdb")
changeManager.hasChanges = true
var truncates: Set<String> = []
var deletes: Set<String> = []
var options: [String: TableOperationOptions] = [:]
coordinator.saveChanges(
pendingTruncates: &truncates,
pendingDeletes: &deletes,
tableOperationOptions: &options
)
let errorMessage = tabManager.tabs.first?.execution.errorMessage
#expect(errorMessage != nil)
#expect(errorMessage?.contains("read-only") == true)
}
@Test("saveChanges on read-only connection does not clear changes")
func readOnly_doesNotClearChanges() {
let (coordinator, _, changeManager) = makeCoordinator(safeModeLevel: .readOnly)
changeManager.hasChanges = true
var truncates: Set<String> = []
var deletes: Set<String> = []
var options: [String: TableOperationOptions] = [:]
coordinator.saveChanges(
pendingTruncates: &truncates,
pendingDeletes: &deletes,
tableOperationOptions: &options
)
#expect(changeManager.hasChanges == true)
}
// MARK: - Empty Generated Statements
@Test("saveChanges with hasChanges true but no generated SQL sets error")
func hasChangesButNoSQL_setsError() {
let (coordinator, tabManager, changeManager) = makeCoordinator()
tabManager.addTab(databaseName: "testdb")
changeManager.hasChanges = true
var truncates: Set<String> = []
var deletes: Set<String> = []
var options: [String: TableOperationOptions] = [:]
coordinator.saveChanges(
pendingTruncates: &truncates,
pendingDeletes: &deletes,
tableOperationOptions: &options
)
let errorMessage = tabManager.tabs.first?.execution.errorMessage
#expect(errorMessage != nil)
}
// MARK: - Pending Table Operations
@Test("saveChanges with pending truncates but read-only sets error")
func pendingTruncatesReadOnly_setsError() {
let (coordinator, tabManager, _) = makeCoordinator(safeModeLevel: .readOnly)
tabManager.addTab(databaseName: "testdb")
var truncates: Set<String> = ["users"]
var deletes: Set<String> = []
var options: [String: TableOperationOptions] = [:]
coordinator.saveChanges(
pendingTruncates: &truncates,
pendingDeletes: &deletes,
tableOperationOptions: &options
)
let errorMessage = tabManager.tabs.first?.execution.errorMessage
#expect(errorMessage != nil)
#expect(errorMessage?.contains("read-only") == true)
#expect(truncates.contains("users"))
}
@Test("saveChanges with no tab selected and read-only does not crash")
func noTabSelected_readOnly_doesNotCrash() {
let (coordinator, _, changeManager) = makeCoordinator(safeModeLevel: .readOnly)
changeManager.hasChanges = true
var truncates: Set<String> = []
var deletes: Set<String> = []
var options: [String: TableOperationOptions] = [:]
coordinator.saveChanges(
pendingTruncates: &truncates,
pendingDeletes: &deletes,
tableOperationOptions: &options
)
#expect(changeManager.hasChanges == true)
}
@Test("saveChanges with no changes and no pending ops does nothing")
func noChangesNoPendingOps_noop() {
let (coordinator, tabManager, _) = makeCoordinator()
tabManager.addTab(databaseName: "testdb")
var truncates: Set<String> = []
var deletes: Set<String> = []
var options: [String: TableOperationOptions] = [:]
coordinator.saveChanges(
pendingTruncates: &truncates,
pendingDeletes: &deletes,
tableOperationOptions: &options
)
#expect(tabManager.tabs.first?.execution.errorMessage == nil)
#expect(truncates.isEmpty)
#expect(deletes.isEmpty)
}
// MARK: - Safe Mode Confirmation Path
@Test("saveChanges with alert level and pending truncates clears inout params immediately")
func alertLevel_pendingTruncates_clearsParams() {
let (coordinator, tabManager, _) = makeCoordinator(safeModeLevel: .alert)
tabManager.addTab(databaseName: "testdb")
var truncates: Set<String> = ["users"]
var deletes: Set<String> = []
var options: [String: TableOperationOptions] = [:]
coordinator.saveChanges(
pendingTruncates: &truncates,
pendingDeletes: &deletes,
tableOperationOptions: &options
)
// Confirmation path clears inout params before returning to prevent double-execution
#expect(truncates.isEmpty)
}
@Test("saveChanges with safeMode level and pending deletes clears inout params")
func safeModeLevel_pendingDeletes_clearsParams() {
let (coordinator, tabManager, _) = makeCoordinator(safeModeLevel: .safeMode)
tabManager.addTab(databaseName: "testdb")
var truncates: Set<String> = []
var deletes: Set<String> = ["orders"]
var options: [String: TableOperationOptions] = [:]
coordinator.saveChanges(
pendingTruncates: &truncates,
pendingDeletes: &deletes,
tableOperationOptions: &options
)
#expect(deletes.isEmpty)
}
@Test("saveChanges with alert level and no changes does nothing")
func alertLevel_noChanges_noop() {
let (coordinator, tabManager, _) = makeCoordinator(safeModeLevel: .alert)
tabManager.addTab(databaseName: "testdb")
var truncates: Set<String> = []
var deletes: Set<String> = []
var options: [String: TableOperationOptions] = [:]
coordinator.saveChanges(
pendingTruncates: &truncates,
pendingDeletes: &deletes,
tableOperationOptions: &options
)
#expect(tabManager.tabs.first?.execution.errorMessage == nil)
#expect(truncates.isEmpty)
#expect(deletes.isEmpty)
}
@Test("saveChanges with silent level and pending truncates clears via normal path")
func silentLevel_pendingTruncates_clearsViaNormalPath() {
let (coordinator, tabManager, _) = makeCoordinator(safeModeLevel: .silent)
tabManager.addTab(databaseName: "testdb")
var truncates: Set<String> = ["users"]
var deletes: Set<String> = []
var options: [String: TableOperationOptions] = [:]
coordinator.saveChanges(
pendingTruncates: &truncates,
pendingDeletes: &deletes,
tableOperationOptions: &options
)
// Silent level takes the normal (non-confirmation) path which also clears immediately
#expect(truncates.isEmpty)
}
// MARK: - Row Operations and Safe Mode
@Test("row operations blocked by readOnly level")
func rowOperations_blockedByReadOnly() {
let (coordinator, tabManager, _) = makeCoordinator(safeModeLevel: .readOnly)
tabManager.addTab(databaseName: "testdb")
if let index = tabManager.selectedTabIndex {
tabManager.tabs[index].tableContext.isEditable = true
tabManager.tabs[index].tableContext.tableName = "users"
}
var editingCell: CellPosition?
coordinator.addNewRow(editingCell: &editingCell)
#expect(coordinator.selectionState.indices.isEmpty)
#expect(editingCell == nil)
coordinator.selectionState.indices = [0]
coordinator.deleteSelectedRows(indices: Set([0]))
#expect(coordinator.selectionState.indices == [0])
coordinator.selectionState.indices = []
coordinator.duplicateSelectedRow(index: 0, editingCell: &editingCell)
#expect(coordinator.selectionState.indices.isEmpty)
#expect(editingCell == nil)
}
@Test("row operations allowed by alert level")
func rowOperations_allowedByAlertLevel() {
let (coordinator, tabManager, _) = makeCoordinator(safeModeLevel: .alert)
tabManager.addTab(databaseName: "testdb")
if let index = tabManager.selectedTabIndex {
tabManager.tabs[index].tableContext.isEditable = true
tabManager.tabs[index].tableContext.tableName = "users"
}
var editingCell: CellPosition?
coordinator.addNewRow(editingCell: &editingCell)
#expect(tabManager.tabs.first?.execution.errorMessage == nil)
}
}