Skip to content

Commit 06108e0

Browse files
committed
fix(datagrid): redraw cells after Cmd+Z when editor view briefly disappears
1 parent 56cacc8 commit 06108e0

2 files changed

Lines changed: 1 addition & 1 deletion

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
6666
- Oracle connections to 23ai cloud and containerized deployments no longer fail with `uncleanShutdown` mid-handshake. OOB urgent-byte send now requires the server to advertise `TNS_ACCEPT_FLAG_CHECK_OOB`, matching python-oracledb behavior (#483)
6767
- Connecting to a downloadable database type (SQL Server, Oracle, MongoDB, DuckDB, BigQuery, libSQL, Cassandra, etcd, Cloudflare D1, DynamoDB) after the plugin is disabled or uninstalled now reopens the install prompt instead of failing with "plugin may be disabled or missing from the PlugIns directory." `PluginMetadataRegistry` now treats the registry default snapshot as the source of truth for the `isDownloadable` flag, so plugin self-registration cannot flip it to false and unregistration restores the default rather than deleting the type metadata (#975)
6868
- Redshift schema switcher no longer shows an empty list for non-admin users. The driver listed schemas via `information_schema.schemata`, which on Redshift only returns schemas the current user *owns* (Redshift diverges from PostgreSQL here, where USAGE is enough). `fetchSchemas` now reads from `pg_namespace` filtered by `has_schema_privilege(current_user, nspname, 'USAGE')`, so any schema the user can actually use appears in the dropdown (#971)
69+
- Cmd+Z after editing a cell no longer leaves the yellow "modified" cell background and modified-row highlight in place. `MainEditorContentView.onDisappear` was explicitly nilling `coordinator.dataTabDelegate`, but SwiftUI fires `onDisappear` on transient lifecycle events even when the `@State` strong owner persists. By the time `NSUndoManager` dispatched the undo, the coordinator's weak ref was nil and the redraw call was silently dropped while pending changes and the toolbar Save button correctly cleared. Removed the explicit nil; the weak ref now clears naturally only when `@State` deallocates on permanent view destruction.
6970

7071
## [0.37.0] - 2026-05-01
7172

TablePro/Views/Main/Child/MainEditorContentView.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@ struct MainEditorContentView: View {
129129
}
130130
.onDisappear {
131131
cachedChangeManager = nil
132-
coordinator.dataTabDelegate = nil
133132
}
134133
.task(id: TabLoadKey(
135134
tabId: tabManager.selectedTabId,

0 commit comments

Comments
 (0)