fix: address review — simplify secretOwnerId, resolve SSH profile at list level

Author: datlechin

TablePro/Core/Database/DatabaseManager.swift

@@ -458,7 +458,7 @@ final class DatabaseManager {
         let profile = connection.sshProfileId.flatMap { SSHProfileStorage.shared.profile(for: $0) }
         let sshConfig = connection.effectiveSSHConfig(profile: profile)
         let isProfile = connection.sshProfileId != nil && profile != nil
-        let secretOwnerId = connection.sshProfileId.flatMap { profile != nil ? $0 : nil } ?? connection.id
+        let secretOwnerId = (isProfile ? connection.sshProfileId : nil) ?? connection.id
 
         guard sshConfig.enabled else {
             return connection

TablePro/Views/Connection/WelcomeWindowView.swift

@@ -464,7 +464,8 @@ struct WelcomeWindowView: View {
     }
 
     private func connectionRow(for connection: DatabaseConnection) -> some View {
-        ConnectionRow(connection: connection, onConnect: { connectToDatabase(connection) })
+        let sshProfile = connection.sshProfileId.flatMap { SSHProfileStorage.shared.profile(for: $0) }
+        return ConnectionRow(connection: connection, sshProfile: sshProfile, onConnect: { connectToDatabase(connection) })
             .tag(connection.id)
             .listRowInsets(ThemeEngine.shared.activeTheme.spacing.listRowInsets.swiftUI)
             .listRowSeparator(.hidden)
@@ -1011,6 +1012,7 @@ struct WelcomeWindowView: View {
 
 private struct ConnectionRow: View {
     let connection: DatabaseConnection
+    let sshProfile: SSHProfile?
     var onConnect: (() -> Void)?
 
     private var displayTag: ConnectionTag? {
@@ -1066,8 +1068,7 @@ private struct ConnectionRow: View {
     }
 
     private var connectionSubtitle: String {
-        let profile = connection.sshProfileId.flatMap { SSHProfileStorage.shared.profile(for: $0) }
-        let ssh = connection.effectiveSSHConfig(profile: profile)
+        let ssh = connection.effectiveSSHConfig(profile: sshProfile)
         if ssh.enabled {
             return "SSH : \(ssh.username)@\(ssh.host)"
         }