fix: replace NSLog with os.Logger, use O(1) string length, fix localization

- SidebarViewModel: replace 5 NSLog calls with os.Logger (sidebarLogger)
- CompletionTextField: string.count → (string as NSString).length for O(1)
- TableProApp: Text("Preview \(name)") → String(format:) to fix localization key

Author: datlechin

TablePro/TableProApp.swift

@@ -218,7 +218,7 @@ struct AppMenuCommands: Commands {
                 actions?.previewSQL()
             } label: {
                 if let dbType = appState.currentDatabaseType {
-                    Text("Preview \(PluginManager.shared.queryLanguageName(for: dbType))")
+                    Text(String(format: String(localized: "Preview %@"), PluginManager.shared.queryLanguageName(for: dbType)))
                 } else {
                     Text("Preview SQL")
                 }

TablePro/ViewModels/SidebarViewModel.swift

@@ -7,6 +7,7 @@
 //
 
 import Observation
+import os
 import SwiftUI
 
 // MARK: - TableFetcher Protocol
@@ -16,6 +17,8 @@ protocol TableFetcher: Sendable {
     func fetchTables(force: Bool) async throws -> [TableInfo]
 }
 
+private let sidebarLogger = Logger(subsystem: "com.TablePro", category: "SidebarViewModel")
+
 /// Production implementation that uses DatabaseManager, with optional schema provider cache
 struct LiveTableFetcher: TableFetcher {
     let connectionId: UUID
@@ -36,12 +39,12 @@ struct LiveTableFetcher: TableFetcher {
             }
         }
         guard let driver = await DatabaseManager.shared.driver(for: connectionId) else {
-            NSLog("[LiveTableFetcher] driver is nil for connectionId: %@", connectionId.uuidString)
+            sidebarLogger.warning("Driver is nil for connection \(connectionId)")
             return []
         }
         let fetched = try await driver.fetchTables()
             .sorted { $0.name.localizedCaseInsensitiveCompare($1.name) == .orderedAscending }
-        NSLog("[LiveTableFetcher] fetched %d tables", fetched.count)
+        sidebarLogger.debug("Fetched \(fetched.count) tables")
         if let provider = schemaProvider {
             await provider.updateTables(fetched)
         }
@@ -155,14 +158,14 @@ final class SidebarViewModel {
 
     func onAppear() {
         guard tables.isEmpty else {
-            NSLog("[SidebarVM] onAppear: tables not empty (%d), skipping", tables.count)
+            sidebarLogger.debug("onAppear: tables not empty (\(self.tables.count)), skipping")
             return
         }
         if DatabaseManager.shared.driver(for: connectionId) != nil {
-            NSLog("[SidebarVM] onAppear: driver found, loading tables")
+            sidebarLogger.debug("onAppear: loading tables")
             loadTables()
         } else {
-            NSLog("[SidebarVM] onAppear: driver is nil for %@", connectionId.uuidString)
+            sidebarLogger.warning("onAppear: driver is nil for \(self.connectionId)")
         }
     }
 

TablePro/Views/Filter/CompletionTextField.swift

@@ -96,7 +96,7 @@ struct CompletionTextField: NSViewRepresentable {
             if commandSelector == #selector(NSResponder.insertNewlineIgnoringFieldEditor(_:)) {
                 textView.insertNewlineIgnoringFieldEditor(nil)
                 text.wrappedValue = textView.string
-                previousTextLength = textView.string.count
+                previousTextLength = (textView.string as NSString).length
                 return true
             }
             return false