Skip to content

Commit 2b6ba92

Browse files
committed
Reapply "revert: restore pre-archive build pipeline (#573)"
This reverts commit 4654c57.
1 parent c2bc74e commit 2b6ba92

File tree

3 files changed

+318
-253
lines changed

3 files changed

+318
-253
lines changed

.github/workflows/build.yml

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -138,13 +138,6 @@ jobs:
138138
build/Release/TablePro-*.dmg
139139
build/Release/TablePro-*.zip
140140
141-
- name: Upload dSYMs
142-
uses: actions/upload-artifact@v4
143-
with:
144-
name: dsyms-arm64
145-
path: build/Release/TablePro-*-dSYMs.zip
146-
if-no-files-found: warn
147-
148141
build-x86_64:
149142
name: Build x86_64
150143
runs-on: macos-15
@@ -263,13 +256,6 @@ jobs:
263256
build/Release/TablePro-*.dmg
264257
build/Release/TablePro-*.zip
265258
266-
- name: Upload dSYMs
267-
uses: actions/upload-artifact@v4
268-
with:
269-
name: dsyms-x86_64
270-
path: build/Release/TablePro-*-dSYMs.zip
271-
if-no-files-found: warn
272-
273259
release:
274260
name: Create GitHub Release
275261
runs-on: macos-15
@@ -293,27 +279,14 @@ jobs:
293279
- name: Download build artifacts
294280
uses: actions/download-artifact@v4
295281
with:
296-
pattern: artifacts-*
297282
path: artifacts-raw/
298283
merge-multiple: true
299284

300-
- name: Download dSYMs
301-
uses: actions/download-artifact@v4
302-
with:
303-
pattern: dsyms-*
304-
path: dsyms-raw/
305-
merge-multiple: true
306-
307285
- name: Flatten artifacts
308286
run: |
309287
mkdir -p artifacts/
310288
find artifacts-raw/ -type f \( -name "*.dmg" -o -name "*.zip" \) -exec mv {} artifacts/ \;
311289
rm -rf artifacts-raw/
312-
313-
# Move dSYMs to artifacts for release attachment
314-
find dsyms-raw/ -name "*-dSYMs.zip" -exec mv {} artifacts/ \; 2>/dev/null || true
315-
rm -rf dsyms-raw/
316-
317290
echo "Artifacts:"
318291
ls -lh artifacts/
319292

scripts/build-plugin.sh

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ build_plugin() {
3737
CODE_SIGN_IDENTITY="$SIGN_IDENTITY" \
3838
CODE_SIGN_STYLE=Manual \
3939
DEVELOPMENT_TEAM="$TEAM_ID" \
40-
DEPLOYMENT_POSTPROCESSING=YES \
41-
STRIP_STYLE=non-global \
4240
-skipPackagePluginValidation \
4341
-derivedDataPath "$DERIVED_DATA_DIR" \
4442
build > "build-plugin-${arch}.log" 2>&1; then
@@ -58,10 +56,17 @@ build_plugin() {
5856

5957
echo "Built: $plugin_bundle" >&2
6058

61-
# Stripping is handled by Xcode build settings (COPY_PHASE_STRIP, DEPLOYMENT_POSTPROCESSING)
59+
# Strip the plugin binary to reduce size
6260
local plugin_name
6361
plugin_name=$(basename "$plugin_bundle" .tableplugin)
6462
local plugin_binary="$plugin_bundle/Contents/MacOS/$plugin_name"
63+
if [ -f "$plugin_binary" ]; then
64+
local before after
65+
before=$(ls -lh "$plugin_binary" | awk '{print $5}')
66+
strip -x "$plugin_binary"
67+
after=$(ls -lh "$plugin_binary" | awk '{print $5}')
68+
echo "Stripped binary: $before -> $after" >&2
69+
fi
6570

6671
# Code sign inside-out: nested frameworks/dylibs first, then binary, then bundle
6772
echo "Code signing with: $SIGN_IDENTITY" >&2

0 commit comments

Comments
 (0)