fix: SSH thread safety, data change protection, connection reliability, and UI improvements (#337)

* fix: SSH thread safety, data change protection, connection reliability, and UI improvements

* chore: remove known-issues tracking doc from repo

* fix: simplify changelog and add vi/zh translations for new strings

* fix: address review findings — relay serialization, pagination state, query counter, dialog guard

* fix: address CodeRabbit review — hop relay safety, stale index, delete cleanup, duplicates

Author: datlechin

CHANGELOG.md

@@ -7,6 +7,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+- Save Changes button in toolbar for committing pending data edits
+- Confirmation dialog before deleting a connection
+- Confirmation dialog before sort, pagination, filter, or search discards unsaved edits
+
+### Fixed
+
+- SSH tunnel crashes caused by concurrent libssh2 calls on the same session
+- Unsaved cell edits lost when switching tabs, sorting, paginating, filtering, or switching apps
+- Auto-reconnect and health monitor silently discarding unsaved changes
+- SSH tunnel recovery failing after tunnel death due to stale driver state
+- Health monitor ping interfering with active user queries
+- Connection test not cleaning up SSH tunnel on completion
+- Test connection success indicator not resetting after field changes
+- SSH port field accepting invalid values
+
 ## [0.19.1] - 2026-03-16
 
 ### Fixed

TablePro/Core/Database/DatabaseManager.swift

@@ -41,6 +41,11 @@ final class DatabaseManager {
     /// Health monitors for active connections (MySQL/PostgreSQL only)
     private var healthMonitors: [UUID: ConnectionHealthMonitor] = [:]
 
+    /// Tracks connections with user queries currently in-flight.
+    /// The health monitor skips pings while a query is running to avoid
+    /// racing on non-thread-safe driver connections.
+    private var queriesInFlight: [UUID: Int] = [:]
+
     /// Current session (computed from currentSessionId)
     var currentSession: ConnectionSession? {
         guard let sessionId = currentSessionId else { return nil }
@@ -311,10 +316,18 @@ final class DatabaseManager {
 
     /// Execute a query on the current session
     func execute(query: String) async throws -> QueryResult {
-        guard let driver = activeDriver else {
+        guard let sessionId = currentSessionId, let driver = activeDriver else {
             throw DatabaseError.notConnected
         }
 
+        queriesInFlight[sessionId, default: 0] += 1
+        defer {
+            if let count = queriesInFlight[sessionId], count > 1 {
+                queriesInFlight[sessionId] = count - 1
+            } else {
+                queriesInFlight.removeValue(forKey: sessionId)
+            }
+        }
         return try await driver.execute(query: query)
     }
 
@@ -346,17 +359,22 @@ final class DatabaseManager {
             sshPasswordOverride: sshPassword
         )
 
-        defer {
-            // Close tunnel after test
+        let result: Bool
+        do {
+            let driver = try DatabaseDriverFactory.createDriver(for: testConnection)
+            result = try await driver.testConnection()
+        } catch {
             if connection.sshConfig.enabled {
-                Task {
-                    try? await SSHTunnelManager.shared.closeTunnel(connectionId: connection.id)
-                }
+                try? await SSHTunnelManager.shared.closeTunnel(connectionId: connection.id)
             }
+            throw error
         }
 
-        let driver = try DatabaseDriverFactory.createDriver(for: testConnection)
-        return try await driver.testConnection()
+        if connection.sshConfig.enabled {
+            try? await SSHTunnelManager.shared.closeTunnel(connectionId: connection.id)
+        }
+
+        return result
     }
 
     // MARK: - SSH Tunnel Helper
@@ -447,6 +465,9 @@ final class DatabaseManager {
             connectionId: connectionId,
             pingHandler: { [weak self] in
                 guard let self else { return false }
+                // Skip ping while a user query is in-flight to avoid racing
+                // on the same non-thread-safe driver connection.
+                guard await self.queriesInFlight[connectionId] == nil else { return true }
                 guard let mainDriver = await self.activeSessions[connectionId]?.driver else {
                     return false
                 }
@@ -638,8 +659,14 @@ final class DatabaseManager {
 
         Self.logger.warning("SSH tunnel died for connection: \(session.connection.name)")
 
-        // Mark connection as reconnecting
+        // Stop health monitor before retrying to prevent stale pings during reconnect
+        await stopHealthMonitor(for: connectionId)
+
+        // Disconnect the stale driver and invalidate it so connectToSession
+        // creates a fresh connection instead of short-circuiting on driver != nil
+        session.driver?.disconnect()
         updateSession(connectionId) { session in
+            session.driver = nil
             session.status = .connecting
         }