fix: address PR review — extract pricing URL constant, add access control, log errors

Author: datlechin

TablePro/Models/Settings/License.swift

@@ -132,7 +132,7 @@ struct LicenseAPIErrorResponse: Codable {
 }
 
 /// Information about a single license activation (machine)
-struct LicenseActivationInfo: Codable, Identifiable {
+internal struct LicenseActivationInfo: Codable, Identifiable {
     var id: String { machineId }
     let machineId: String
     let machineName: String
@@ -152,7 +152,7 @@ struct LicenseActivationInfo: Codable, Identifiable {
 }
 
 /// Response from the list activations endpoint
-struct ListActivationsResponse: Codable {
+internal struct ListActivationsResponse: Codable {
     let activations: [LicenseActivationInfo]
     let maxActivations: Int
 

TablePro/Resources/Localizable.xcstrings

@@ -303,6 +303,9 @@
           }
         }
       }
+    },
+    "(this Mac)" : {
+
     },
     "/path/to/agent.sock" : {
       "localizations" : {
@@ -371,6 +374,16 @@
         }
       }
     },
+    "%@ (%@@%@)" : {
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "new",
+            "value" : "%1$@ (%2$@@%3$@)"
+          }
+        }
+      }
+    },
     "%@ (%lld/%lld)" : {
       "localizations" : {
         "en" : {
@@ -901,6 +914,9 @@
           }
         }
       }
+    },
+    "%lld connection(s) use this profile. They will fall back to no SSH tunnel." : {
+
     },
     "%lld in · %lld out" : {
       "localizations" : {
@@ -2375,6 +2391,16 @@
         }
       }
     },
+    "Activations (%lld of %lld)" : {
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "new",
+            "value" : "Activations (%1$lld of %2$lld)"
+          }
+        }
+      }
+    },
     "Active" : {
       "localizations" : {
         "tr" : {
@@ -3699,6 +3725,9 @@
           }
         }
       }
+    },
+    "Auth Method" : {
+
     },
     "Authenticate to execute database operations" : {
       "localizations" : {
@@ -4159,6 +4188,9 @@
           }
         }
       }
+    },
+    "Billing:" : {
+
     },
     "Blue" : {
       "localizations" : {
@@ -4774,6 +4806,9 @@
           }
         }
       }
+    },
+    "Check Status" : {
+
     },
     "Choose a query from the list\nto see its full content here." : {
       "localizations" : {
@@ -5893,6 +5928,9 @@
           }
         }
       }
+    },
+    "Connect to the internet to verify your license." : {
+
     },
     "Connected" : {
       "localizations" : {
@@ -7007,6 +7045,9 @@
           }
         }
       }
+    },
+    "Create New Profile..." : {
+
     },
     "Create New Tag" : {
       "localizations" : {
@@ -8587,6 +8628,12 @@
           }
         }
       }
+    },
+    "Delete Profile" : {
+
+    },
+    "Delete SSH Profile?" : {
+
     },
     "Delete Theme" : {
       "localizations" : {
@@ -9369,6 +9416,9 @@
           }
         }
       }
+    },
+    "Edit Profile..." : {
+
     },
     "Edit Provider" : {
       "localizations" : {
@@ -10239,6 +10289,9 @@
           }
         }
       }
+    },
+    "Expires:" : {
+
     },
     "Explain" : {
       "localizations" : {
@@ -13294,6 +13347,9 @@
           }
         }
       }
+    },
+    "Inline Configuration" : {
+
     },
     "Inline Suggestions" : {
       "localizations" : {
@@ -14549,6 +14605,9 @@
           }
         }
       }
+    },
+    "License expires in %lld day(s)" : {
+
     },
     "License Key:" : {
       "localizations" : {
@@ -14571,6 +14630,12 @@
           }
         }
       }
+    },
+    "License validation failed" : {
+
+    },
+    "Lifetime" : {
+
     },
     "Light" : {
       "localizations" : {
@@ -15516,6 +15581,9 @@
           }
         }
       }
+    },
+    "My Server" : {
+
     },
     "Name" : {
       "localizations" : {
@@ -16084,6 +16152,9 @@
           }
         }
       }
+    },
+    "No activations found" : {
+
     },
     "No active connection" : {
       "localizations" : {
@@ -19737,6 +19808,12 @@
           }
         }
       }
+    },
+    "Profile" : {
+
+    },
+    "Profile Settings" : {
+
     },
     "Prompt at Connect" : {
       "localizations" : {
@@ -19804,6 +19881,9 @@
           }
         }
       }
+    },
+    "Purchase License" : {
+
     },
     "Purple" : {
       "localizations" : {
@@ -20739,6 +20819,9 @@
           }
         }
       }
+    },
+    "Refresh license status from server" : {
+
     },
     "Refreshing will discard all unsaved changes." : {
       "localizations" : {
@@ -20903,6 +20986,12 @@
           }
         }
       }
+    },
+    "Renew" : {
+
+    },
+    "Renew License" : {
+
     },
     "Renew License..." : {
       "localizations" : {
@@ -21143,6 +21232,9 @@
           }
         }
       }
+    },
+    "Retry Validation" : {
+
     },
     "Reuse clean table tab" : {
       "extractionState" : "stale",
@@ -21778,6 +21870,9 @@
           }
         }
       }
+    },
+    "Save Current as Profile..." : {
+
     },
     "Save Failed" : {
       "localizations" : {
@@ -22629,6 +22724,9 @@
           }
         }
       }
+    },
+    "Selected SSH profile no longer exists." : {
+
     },
     "Selection" : {
       "localizations" : {
@@ -23954,6 +24052,12 @@
           }
         }
       }
+    },
+    "SSH Profile" : {
+
+    },
+    "SSH Profiles:" : {
+
     },
     "SSH Tunnel" : {
       "extractionState" : "stale",
@@ -24335,6 +24439,9 @@
           }
         }
       }
+    },
+    "Status:" : {
+
     },
     "Stop" : {
       "localizations" : {
@@ -24634,6 +24741,9 @@
           }
         }
       }
+    },
+    "Switch to Inline Configuration" : {
+
     },
     "Sync" : {
       "localizations" : {
@@ -25671,6 +25781,9 @@
           }
         }
       }
+    },
+    "This profile will be permanently deleted." : {
+
     },
     "This query may permanently modify or delete data." : {
       "localizations" : {
@@ -25860,6 +25973,9 @@
           }
         }
       }
+    },
+    "Tier:" : {
+
     },
     "TIMESTAMPS" : {
       "localizations" : {

TablePro/Views/Components/ProFeatureGate.swift

@@ -12,6 +12,8 @@ struct ProFeatureGateModifier: ViewModifier {
     let feature: ProFeature
 
     private let licenseManager = LicenseManager.shared
+    // swiftlint:disable:next force_unwrapping
+    private static let pricingURL = URL(string: "https://tablepro.app/#pricing")!
 
     func body(content: Content) -> some View {
         let available = licenseManager.isFeatureAvailable(feature)
@@ -51,7 +53,7 @@ struct ProFeatureGateModifier: ViewModifier {
                         openLicenseSettings()
                     }
                     .buttonStyle(.borderedProminent)
-                    Link(String(localized: "Renew License"), destination: URL(string: "https://tablepro.app/pricing")!)
+                    Link(String(localized: "Renew License"), destination: Self.pricingURL)
                         .font(.subheadline)
                 case .validationFailed:
                     Text("License validation failed")
@@ -73,7 +75,7 @@ struct ProFeatureGateModifier: ViewModifier {
                         openLicenseSettings()
                     }
                     .buttonStyle(.borderedProminent)
-                    Link(String(localized: "Purchase License"), destination: URL(string: "https://tablepro.app/pricing")!)
+                    Link(String(localized: "Purchase License"), destination: Self.pricingURL)
                         .font(.subheadline)
                 }
             }