Skip to content

Commit 4654c57

Browse files
committed
Revert "revert: restore pre-archive build pipeline (#573)"
This reverts commit 227744b.
1 parent 227744b commit 4654c57

File tree

3 files changed

+253
-318
lines changed

3 files changed

+253
-318
lines changed

.github/workflows/build.yml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,13 @@ jobs:
138138
build/Release/TablePro-*.dmg
139139
build/Release/TablePro-*.zip
140140
141+
- name: Upload dSYMs
142+
uses: actions/upload-artifact@v4
143+
with:
144+
name: dsyms-arm64
145+
path: build/Release/TablePro-*-dSYMs.zip
146+
if-no-files-found: warn
147+
141148
build-x86_64:
142149
name: Build x86_64
143150
runs-on: macos-15
@@ -256,6 +263,13 @@ jobs:
256263
build/Release/TablePro-*.dmg
257264
build/Release/TablePro-*.zip
258265
266+
- name: Upload dSYMs
267+
uses: actions/upload-artifact@v4
268+
with:
269+
name: dsyms-x86_64
270+
path: build/Release/TablePro-*-dSYMs.zip
271+
if-no-files-found: warn
272+
259273
release:
260274
name: Create GitHub Release
261275
runs-on: macos-15
@@ -279,14 +293,27 @@ jobs:
279293
- name: Download build artifacts
280294
uses: actions/download-artifact@v4
281295
with:
296+
pattern: artifacts-*
282297
path: artifacts-raw/
283298
merge-multiple: true
284299

300+
- name: Download dSYMs
301+
uses: actions/download-artifact@v4
302+
with:
303+
pattern: dsyms-*
304+
path: dsyms-raw/
305+
merge-multiple: true
306+
285307
- name: Flatten artifacts
286308
run: |
287309
mkdir -p artifacts/
288310
find artifacts-raw/ -type f \( -name "*.dmg" -o -name "*.zip" \) -exec mv {} artifacts/ \;
289311
rm -rf artifacts-raw/
312+
313+
# Move dSYMs to artifacts for release attachment
314+
find dsyms-raw/ -name "*-dSYMs.zip" -exec mv {} artifacts/ \; 2>/dev/null || true
315+
rm -rf dsyms-raw/
316+
290317
echo "Artifacts:"
291318
ls -lh artifacts/
292319

scripts/build-plugin.sh

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ build_plugin() {
3737
CODE_SIGN_IDENTITY="$SIGN_IDENTITY" \
3838
CODE_SIGN_STYLE=Manual \
3939
DEVELOPMENT_TEAM="$TEAM_ID" \
40+
DEPLOYMENT_POSTPROCESSING=YES \
41+
STRIP_STYLE=non-global \
4042
-skipPackagePluginValidation \
4143
-derivedDataPath "$DERIVED_DATA_DIR" \
4244
build > "build-plugin-${arch}.log" 2>&1; then
@@ -56,17 +58,10 @@ build_plugin() {
5658

5759
echo "Built: $plugin_bundle" >&2
5860

59-
# Strip the plugin binary to reduce size
61+
# Stripping is handled by Xcode build settings (COPY_PHASE_STRIP, DEPLOYMENT_POSTPROCESSING)
6062
local plugin_name
6163
plugin_name=$(basename "$plugin_bundle" .tableplugin)
6264
local plugin_binary="$plugin_bundle/Contents/MacOS/$plugin_name"
63-
if [ -f "$plugin_binary" ]; then
64-
local before after
65-
before=$(ls -lh "$plugin_binary" | awk '{print $5}')
66-
strip -x "$plugin_binary"
67-
after=$(ls -lh "$plugin_binary" | awk '{print $5}')
68-
echo "Stripped binary: $before -> $after" >&2
69-
fi
7065

7166
# Code sign inside-out: nested frameworks/dylibs first, then binary, then bundle
7267
echo "Code signing with: $SIGN_IDENTITY" >&2

0 commit comments

Comments
 (0)