refactor: cleanup code quality issues from review

- SearchFieldView: resolve theme font size inside body for reactivity
- HorizontalSplitView: refresh binding in updateNSView to prevent stale reference
- HorizontalSplitView: add 0.5pt threshold to resize callback to reduce re-renders
- HorizontalSplitView: remove redundant splitView.display() calls
- ConnectionSwitcherPopover: extract moveSelection helper to avoid repeated allItems computation
- ContentView: remove dead saveCurrentSessionState stub

Author: datlechin

TablePro/ContentView.swift

@@ -429,10 +429,6 @@ struct ContentView: View {
         }
     }
 
-    private func saveCurrentSessionState() {
-        // State is automatically saved through bindings
-    }
-
     // MARK: - Persistence
 
     private func deleteConnection(_ connection: DatabaseConnection) {

TablePro/Views/Components/HorizontalSplitView.swift

@@ -51,6 +51,7 @@ struct HorizontalSplitView<Leading: View, Trailing: View>: NSViewRepresentable {
     func updateNSView(_ splitView: NSSplitView, context: Context) {
         context.coordinator.leadingHosting?.rootView = leading
         context.coordinator.trailingHosting?.rootView = trailing
+        context.coordinator.trailingWidth = $trailingWidth
         context.coordinator.minWidth = minTrailingWidth
         context.coordinator.maxWidth = maxTrailingWidth
 
@@ -65,13 +66,11 @@ struct HorizontalSplitView<Leading: View, Trailing: View>: NSViewRepresentable {
                 }
                 splitView.setPosition(splitView.bounds.width, ofDividerAt: 0)
                 trailingView.isHidden = true
-                splitView.display()
             } else {
                 trailingView.isHidden = false
                 let targetWidth = context.coordinator.savedDividerPosition ?? trailingWidth
                 splitView.adjustSubviews()
                 splitView.setPosition(splitView.bounds.width - targetWidth, ofDividerAt: 0)
-                splitView.display()
             }
         }
     }
@@ -81,8 +80,8 @@ struct HorizontalSplitView<Leading: View, Trailing: View>: NSViewRepresentable {
         var trailingHosting: NSHostingView<Trailing>?
         var lastCollapsedState = false
         var savedDividerPosition: CGFloat?
-        var minWidth: CGFloat = 200
-        var maxWidth: CGFloat = 600
+        var minWidth: CGFloat = 0
+        var maxWidth: CGFloat = 0
         var trailingWidth: Binding<CGFloat>
 
         init(trailingWidth: Binding<CGFloat>) {
@@ -137,9 +136,8 @@ struct HorizontalSplitView<Leading: View, Trailing: View>: NSViewRepresentable {
                   trailingHosting?.isHidden != true
             else { return }
             let width = splitView.subviews[1].frame.width
-            if width > 0 {
-                trailingWidth.wrappedValue = width
-            }
+            guard width > 0, abs(width - trailingWidth.wrappedValue) > 0.5 else { return }
+            trailingWidth.wrappedValue = width
         }
     }
 }

TablePro/Views/Components/SearchFieldView.swift

@@ -8,17 +8,18 @@ import SwiftUI
 struct SearchFieldView: View {
     let placeholder: String
     @Binding var text: String
-    var fontSize: CGFloat = ThemeEngine.shared.activeTheme.typography.body
+    var fontSize: CGFloat?
 
     var body: some View {
+        let resolvedSize = fontSize ?? ThemeEngine.shared.activeTheme.typography.body
         HStack(spacing: 6) {
             Image(systemName: "magnifyingglass")
-                .font(.system(size: fontSize))
+                .font(.system(size: resolvedSize))
                 .foregroundStyle(.tertiary)
 
             TextField(placeholder, text: $text)
                 .textFieldStyle(.plain)
-                .font(.system(size: fontSize))
+                .font(.system(size: resolvedSize))
 
             if !text.isEmpty {
                 Button { text = "" } label: {

TablePro/Views/Toolbar/ConnectionSwitcherPopover.swift

@@ -168,22 +168,18 @@ struct ConnectionSwitcherPopover: View {
             return .handled
         }
         .onKeyPress(.upArrow) {
-            if selectedIndex > 0 { selectedIndex -= 1 }
-            return .handled
+            moveSelection(by: -1)
         }
         .onKeyPress(.downArrow) {
-            if selectedIndex < allItems.count - 1 { selectedIndex += 1 }
-            return .handled
+            moveSelection(by: 1)
         }
         .onKeyPress(characters: .init(charactersIn: "j"), phases: [.down, .repeat]) { keyPress in
             guard keyPress.modifiers.contains(.control) else { return .ignored }
-            if selectedIndex < allItems.count - 1 { selectedIndex += 1 }
-            return .handled
+            return moveSelection(by: 1)
         }
         .onKeyPress(characters: .init(charactersIn: "k"), phases: [.down, .repeat]) { keyPress in
             guard keyPress.modifiers.contains(.control) else { return .ignored }
-            if selectedIndex > 0 { selectedIndex -= 1 }
-            return .handled
+            return moveSelection(by: -1)
         }
     }
 
@@ -194,6 +190,13 @@ struct ConnectionSwitcherPopover: View {
         case saved(DatabaseConnection)
     }
 
+    private func moveSelection(by offset: Int) -> KeyPress.Result {
+        let newIndex = selectedIndex + offset
+        guard newIndex >= 0, newIndex < allItems.count else { return .handled }
+        selectedIndex = newIndex
+        return .handled
+    }
+
     // MARK: - Subviews
 
     private func connectionRow(