fix: resolve all codebase audit issues (critical through low) (#871)

* fix: add scroll support for connection form and group delete confirmation

* fix: resolve plugin bundle thread-safety race in principalClass access

* fix: resolve 3 critical code issues from codebase audit

* fix: export preference persistence, connection error feedback, accessible fonts

* fix: persist window frame and toolbar customization

* fix: remove fixed settings window frame, allow content-sized tabs

* fix: use standard About panel, consolidate double-click detection

* fix: eliminate AnyView erasure, add task cancellation, async plugin loading

* fix: split frame modifiers to fix SwiftUI overload resolution

* fix: restore fixed settings window frame

* fix: export format gating, flexible layouts for welcome and SSH views

* fix: improve accessibility labels, interaction feedback, and HIG typography

* fix: pre-compute group depths, weak self capture, log cancel errors, shared codecs

* fix: improve UX feedback across settings, export, and connection views

* fix: replace notification coupling and private API dark mode detection

* fix: add Edit > Find menu item and evaluate toolbar HIG compliance

* fix: drain pending libpq results before streaming to prevent concurrent query error

* fix: constrain database switcher segmented picker width

* fix: native file importer, remove iOS gestures, improve accessibility labels

* fix: increase onboarding page dot tap targets

* fix: let native List handle click and arrow key selection in dialogs

* fix: use standalone NSOpenPanel for SSH key file picker

* docs: simplify changelog entries

Author: datlechin

CHANGELOG.md

@@ -7,9 +7,29 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+- Edit > Find menu item (Cmd+F)
+
+### Fixed
+
+- Export "Don't show again" preference lost when clicking "Open Folder"
+- Connection failure error not shown on welcome screen
+- Window position not restored between launches
+- Export multi-table race condition on PostgreSQL
+- List selection requiring two clicks in Quick Switcher and Database Switcher
+- AI provider and connection test states not clearing on field changes
+- Export stop button missing confirmation dialog
+- SSH profile test showing modal alert instead of inline error
+- DDL results showing misleading "0 row(s) affected"
+- Export dialog missing empty state when no tables found
+
 ### Changed
 
-- iOS: TabView navigation with ConnectionCoordinator extraction and coordinator caching
+- About window uses standard macOS panel
+- Consolidated double-click detection into single shared component
+- Accessibility improvements: VoiceOver labels, semantic fonts, larger tap targets
+- iOS: TabView navigation with ConnectionCoordinator extraction
 
 ## [0.35.0] - 2026-04-25
 

LocalPackages/CodeEditSourceEditor/Sources/CodeEditSourceEditor/Controller/TextViewController+FindPanelTarget.swift

@@ -29,3 +29,10 @@ extension TextViewController: FindPanelTarget {
         textView?.emphasisManager
     }
 }
+
+public extension TextViewController {
+    func showFindPanel() {
+        _ = textView.resignFirstResponder()
+        findViewController?.showFindPanel()
+    }
+}

Plugins/PostgreSQLDriverPlugin/LibPQPluginConnection.swift

@@ -485,6 +485,8 @@ final class LibPQPluginConnection: @unchecked Sendable {
                     return
                 }
 
+                while let res = PQgetResult(conn) { PQclear(res) }
+
                 let sendOk = queryToRun.withCString { queryPtr in
                     PQsendQuery(conn, queryPtr)
                 }

TablePro/Core/Database/DatabaseDriver.swift

@@ -420,21 +420,6 @@ enum DatabaseDriverFactory {
         return try createDriverFromPlugin(for: connection, passwordOverride: passwordOverride)
     }
 
-    /// Sync variant — falls back to synchronous plugin loading if needed.
-    /// Only use when an async context is not available.
-    static func createDriver(
-        for connection: DatabaseConnection,
-        passwordOverride: String? = nil
-    ) throws -> DatabaseDriver {
-        let pluginId = connection.type.pluginTypeId
-        if PluginManager.shared.driverPlugins[pluginId] == nil,
-           !PluginManager.shared.hasFinishedInitialLoad {
-            logger.warning("Plugin '\(pluginId)' not loaded yet — performing synchronous load")
-            PluginManager.shared.loadPendingPlugins()
-        }
-        return try createDriverFromPlugin(for: connection, passwordOverride: passwordOverride)
-    }
-
     private static func createDriverFromPlugin(
         for connection: DatabaseConnection,
         passwordOverride: String? = nil

TablePro/Core/Plugins/PluginManager+Registration.swift

@@ -421,7 +421,7 @@ extension PluginManager {
         }) {
             if !existingEntry.isEnabled {
                 setEnabled(true, pluginId: existingEntry.id)
-                loadPendingPlugins()
+                await loadPendingPluginsAsync()
             }
             if driverPlugins[pluginTypeId] != nil {
                 Self.logger.info("Re-enabled existing plugin '\(existingEntry.name)' for '\(databaseType.rawValue)'")

TablePro/Core/Plugins/PluginManager.swift

@@ -297,9 +297,21 @@ final class PluginManager {
         Self.logger.info("Discovered \(self.pendingPluginURLs.count) plugin(s), will load on first use")
     }
 
-    /// Load all discovered but not-yet-loaded plugin bundles synchronously on MainActor.
-    /// Only used by install/uninstall paths that need immediate plugin availability.
-    /// Normal startup uses `loadPlugins()` which loads bundles off the main thread.
+    func loadPendingPluginsAsync(clearRestartFlag: Bool = false) async {
+        if clearRestartFlag {
+            needsRestartStorage = false
+        }
+        guard !pendingPluginURLs.isEmpty else { return }
+        let pending = pendingPluginURLs
+        pendingPluginURLs.removeAll()
+
+        let loaded = await Self.loadBundlesOffMain(pending)
+        registerLoadedPlugins(loaded)
+        hasFinishedInitialLoad = true
+        validateDependencies()
+        Self.logger.info("Loaded \(self.plugins.count) plugin(s): \(self.driverPlugins.count) driver(s), \(self.exportPlugins.count) export format(s), \(self.importPlugins.count) import format(s)")
+    }
+
     func loadPendingPlugins(clearRestartFlag: Bool = false) {
         if clearRestartFlag {
             needsRestartStorage = false

TablePro/Core/Services/Infrastructure/MainWindowToolbar.swift

@@ -164,6 +164,7 @@ internal final class MainWindowToolbar: NSObject, NSToolbarDelegate {
             return hostingItem(id: itemIdentifier, label: "",
                                content: ToolbarPrincipalContent(
                                    state: coordinator.toolbarState,
+                                   onSwitchDatabase: { [weak coordinator] in coordinator?.commandActions?.openDatabaseSwitcher() },
                                    onCancelQuery: { [weak coordinator] in coordinator?.cancelCurrentQuery() }
                                ))
         case Self.quickSwitcher:

TablePro/Core/Services/Infrastructure/TabWindowController.swift

@@ -69,6 +69,7 @@ internal final class TabWindowController: NSWindowController, NSWindowDelegate {
         window.identifier = NSUserInterfaceItemIdentifier("main")
         window.minSize = NSSize(width: 720, height: 480)
         window.isRestorable = false
+        window.setFrameAutosaveName("MainEditorWindow")
         window.toolbarStyle = .unified
         // Hide the window title ("Query 1 / TablePro") embedded in the unified
         // toolbar — otherwise it claims leading space and pushes our navigation

TablePro/Core/Services/Query/SchemaProviderRegistry.swift

@@ -49,9 +49,9 @@ final class SchemaProviderRegistry {
         count -= 1
         if count <= 0 {
             refCounts.removeValue(forKey: connectionId)
-            removalTasks[connectionId] = Task {
+            removalTasks[connectionId] = Task { [weak self] in
                 try? await Task.sleep(nanoseconds: 5_000_000_000)
-                guard !Task.isCancelled else { return }
+                guard let self, !Task.isCancelled else { return }
                 self.providers.removeValue(forKey: connectionId)
                 self.removalTasks.removeValue(forKey: connectionId)
             }

TablePro/Core/Storage/ConnectionStorage.swift

@@ -386,6 +386,9 @@ final class ConnectionStorage {
 // MARK: - Stored Connection (Codable wrapper)
 
 private struct StoredConnection: Codable {
+    static let sharedEncoder = JSONEncoder()
+    static let sharedDecoder = JSONDecoder()
+
     let id: UUID
     let name: String
     let host: String
@@ -524,7 +527,7 @@ private struct StoredConnection: Codable {
         self.localOnly = connection.localOnly
 
         // SSH tunnel mode (v2 format preserving jump hosts, profiles, etc.)
-        self.sshTunnelModeJson = try? JSONEncoder().encode(connection.sshTunnelMode)
+        self.sshTunnelModeJson = try? Self.sharedEncoder.encode(connection.sshTunnelMode)
 
         // Plugin-driven additional fields
         self.additionalFields = connection.additionalFields.isEmpty ? nil : connection.additionalFields
@@ -670,7 +673,7 @@ private struct StoredConnection: Codable {
         // Prefer sshTunnelModeJson (v2 format) over legacy flat fields
         let resolvedTunnelMode: SSHTunnelMode
         if let json = sshTunnelModeJson,
-           let decoded = try? JSONDecoder().decode(SSHTunnelMode.self, from: json) {
+           let decoded = try? Self.sharedDecoder.decode(SSHTunnelMode.self, from: json) {
             resolvedTunnelMode = decoded
             switch decoded {
             case .disabled: