fix: FK audit — always quote values, use OSLog, log FK fetch errors, remove dead code

Author: datlechin

TableProMobile/TableProMobile/Views/Components/FKPreviewView.swift

@@ -3,6 +3,7 @@
 //  TableProMobile
 //
 
+import os
 import SwiftUI
 import TableProDatabase
 import TableProModels
@@ -14,6 +15,8 @@ struct FKPreviewItem: Identifiable {
 }
 
 struct FKPreviewView: View {
+    private static let logger = Logger(subsystem: "com.TablePro", category: "FKPreviewView")
+
     @Environment(\.dismiss) private var dismiss
     let fk: ForeignKeyInfo
     let value: String
@@ -71,18 +74,13 @@ struct FKPreviewView: View {
         do {
             let quoted = SQLBuilder.quoteIdentifier(fk.referencedTable, for: databaseType)
             let quotedCol = SQLBuilder.quoteIdentifier(fk.referencedColumn, for: databaseType)
-            let sqlValue: String
-            if Int64(value) != nil || Double(value) != nil {
-                sqlValue = value
-            } else {
-                sqlValue = "'\(value.replacingOccurrences(of: "'", with: "''"))'"
-            }
-            let query = "SELECT * FROM \(quoted) WHERE \(quotedCol) = \(sqlValue) LIMIT 1"
+            let escapedValue = value.replacingOccurrences(of: "'", with: "''")
+            let query = "SELECT * FROM \(quoted) WHERE \(quotedCol) = '\(escapedValue)' LIMIT 1"
             let result = try await session.driver.execute(query: query)
             columns = result.columns
             row = result.rows.first
         } catch {
-            print("FK preview error: \(error)")
+            Self.logger.warning("FK preview failed: \(error.localizedDescription, privacy: .public)")
             row = nil
         }
         isLoading = false

TableProMobile/TableProMobile/Views/DataBrowserView.swift

@@ -450,7 +450,11 @@ struct DataBrowserView: View {
                 columnDetails = try await session.driver.fetchColumns(table: table.name, schema: nil)
             }
             if foreignKeys.isEmpty {
-                foreignKeys = (try? await session.driver.fetchForeignKeys(table: table.name, schema: nil)) ?? []
+                do {
+                    foreignKeys = try await session.driver.fetchForeignKeys(table: table.name, schema: nil)
+                } catch {
+                    Self.logger.warning("Failed to fetch foreign keys: \(error.localizedDescription, privacy: .public)")
+                }
             }
             if pagination.totalRows == nil {
                 await fetchTotalRows(session: session)

TableProMobile/TableProMobile/Views/RowDetailView.swift

@@ -198,7 +198,6 @@ struct RowDetailView: View {
             ToolbarItemGroup(placement: .bottomBar) {
                 Button {
                     withAnimation { currentIndex -= 1 }
-                    if isEditing { startEditing() }
                 } label: {
                     Image(systemName: "chevron.left")
                 }
@@ -216,7 +215,6 @@ struct RowDetailView: View {
 
                 Button {
                     withAnimation { currentIndex += 1 }
-                    if isEditing { startEditing() }
                 } label: {
                     Image(systemName: "chevron.right")
                 }
@@ -350,6 +348,7 @@ struct RowDetailView: View {
 
         guard !changes.isEmpty else {
             isEditing = false
+            editedValues = []
             return
         }