fix(settings): persist font size changes in Appearance theme editor (#1381) (#1415)

Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>
Co-authored-by: zhaojianyong <zhaojianyong@unipus.cn>
Co-authored-by: Ngô Quốc Đạt <datlechin@gmail.com>

Author: 3 people

CHANGELOG.md

@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Changing the editor or data grid font size in Appearance settings now applies immediately and persists across relaunch, instead of resetting and leaving orphan custom themes behind (#1381)
 ### Added
 
 - Cloudflare Tunnel: connect to a database behind Cloudflare Access by letting TablePro start and stop `cloudflared access tcp` for you, the same way it manages SSH tunnels. Configure it per connection with browser sign-in or a service token. Needs cloudflared installed (`brew install cloudflared`). (#1285)

TablePro/Theme/ThemeEngine.swift

@@ -150,9 +150,14 @@ internal final class ThemeEngine {
 
     func saveUserTheme(_ theme: ThemeDefinition) throws {
         try ThemeStorage.saveUserTheme(theme)
+
+        if let index = availableThemes.firstIndex(where: { $0.id == theme.id }) {
+            availableThemes[index] = theme
+        } else {
+            availableThemes.append(theme)
+        }
         reloadAvailableThemes()
 
-        // If editing the active theme, re-activate to apply changes
         if theme.id == activeTheme.id {
             activateTheme(theme)
         }

TablePro/Views/Settings/Appearance/ThemeEditorFontsSection.swift

@@ -123,7 +123,6 @@ struct ThemeEditorFontsSection: View {
             var copy = engine.duplicateTheme(base, newName: base.name + " (Custom)")
             mutate(&copy.fonts)
             try? engine.saveUserTheme(copy)
-            engine.activateTheme(copy)
             editingTheme = copy
             onThemeDuplicated?(copy)
         } else {