refactor: use Sparkle generate_appcast instead of custom XML generation

Author: datlechin

scripts/ci/sign-and-appcast.sh

@@ -1,13 +1,15 @@
 #!/usr/bin/env bash
 set -euo pipefail
 
-# Signs release archives with Sparkle EdDSA and generates/updates appcast.xml.
+# Signs release archives and generates appcast.xml using Sparkle's
+# generate_appcast — the official tool for building Sparkle update feeds.
+#
+# generate_appcast handles: EdDSA signing, architecture detection,
+# version extraction from Info.plist, CDATA release notes, and merging
+# new items into an existing appcast (preserving history).
 #
 # Usage: sign-and-appcast.sh <version>
 # Requires: SPARKLE_PRIVATE_KEY env var, artifacts/ directory with ZIPs.
-#
-# The appcast.xml preserves history — new items are prepended to the existing
-# feed so Sparkle shows cumulative release notes for users skipping versions.
 
 VERSION="${1:?Usage: sign-and-appcast.sh <version>}"
 
@@ -23,58 +25,31 @@ brew list --cask sparkle &>/dev/null || brew install --cask sparkle
 SPARKLE_BIN="$(brew --caskroom)/sparkle/$(ls "$(brew --caskroom)/sparkle" | head -1)/bin"
 
 # ---------------------------------------------------------------------------
-# 2. Sign archives with EdDSA
+# 2. Prepare staging directory
 # ---------------------------------------------------------------------------
-ARM64_ZIP="artifacts/TablePro-${VERSION}-arm64.zip"
-X86_64_ZIP="artifacts/TablePro-${VERSION}-x86_64.zip"
-
-KEY_FILE=$(mktemp)
-trap 'rm -f "$KEY_FILE"' EXIT
-echo "$SPARKLE_PRIVATE_KEY" > "$KEY_FILE"
+STAGING=$(mktemp -d)
+trap 'rm -rf "$STAGING"' EXIT
 
-parse_sig() {
-  local output="$1" field="$2"
-  echo "$output" | sed -n "s/.*${field}=\"\\([^\"]*\\)\".*/\\1/p"
-}
-
-ARM64_SIG=$("$SPARKLE_BIN/sign_update" "$ARM64_ZIP" -f "$KEY_FILE")
-X86_64_SIG=$("$SPARKLE_BIN/sign_update" "$X86_64_ZIP" -f "$KEY_FILE")
-
-ARM64_ED_SIG=$(parse_sig "$ARM64_SIG" "sparkle:edSignature")
-ARM64_LENGTH=$(parse_sig "$ARM64_SIG" "length")
-X86_64_ED_SIG=$(parse_sig "$X86_64_SIG" "sparkle:edSignature")
-X86_64_LENGTH=$(parse_sig "$X86_64_SIG" "length")
-
-# ---------------------------------------------------------------------------
-# 3. Extract version metadata from the built app
-# ---------------------------------------------------------------------------
-TEMP_DIR=$(mktemp -d)
-unzip -q "$ARM64_ZIP" -d "$TEMP_DIR"
-INFO_PLIST=$(find "$TEMP_DIR" -maxdepth 3 -path "*/Contents/Info.plist" | head -1)
+# Copy archives
+cp "artifacts/TablePro-${VERSION}-arm64.zip" "$STAGING/"
+cp "artifacts/TablePro-${VERSION}-x86_64.zip" "$STAGING/"
 
-if [ -n "$INFO_PLIST" ] && [ -f "$INFO_PLIST" ]; then
-  BUILD_NUMBER=$(/usr/libexec/PlistBuddy -c "Print :CFBundleVersion" "$INFO_PLIST" 2>/dev/null || echo "1")
-  SHORT_VERSION=$(/usr/libexec/PlistBuddy -c "Print :CFBundleShortVersionString" "$INFO_PLIST" 2>/dev/null || echo "$VERSION")
-  MIN_OS=$(/usr/libexec/PlistBuddy -c "Print :LSMinimumSystemVersion" "$INFO_PLIST" 2>/dev/null || echo "14.0")
-else
-  echo "⚠️  Could not find app Info.plist in ZIP, using defaults"
-  BUILD_NUMBER="1"
-  SHORT_VERSION="$VERSION"
-  MIN_OS="14.0"
+# Copy existing appcast for history preservation
+if [ -f appcast.xml ]; then
+  cp appcast.xml "$STAGING/"
 fi
-rm -rf "$TEMP_DIR"
 
 # ---------------------------------------------------------------------------
-# 4. Extract release notes from CHANGELOG.md → HTML
+# 3. Extract release notes from CHANGELOG.md → HTML
 # ---------------------------------------------------------------------------
 if [ -f release_notes.md ]; then
-    NOTES=$(cat release_notes.md)
+  NOTES=$(cat release_notes.md)
 else
-    NOTES=$(awk "/^## \\[${VERSION}\\]/{flag=1; next} /^## \\[/{flag=0} flag" CHANGELOG.md)
+  NOTES=$(awk "/^## \\[${VERSION}\\]/{flag=1; next} /^## \\[/{flag=0} flag" CHANGELOG.md)
 fi
 
 if [ -z "$NOTES" ]; then
-  RELEASE_HTML="<li>Bug fixes and improvements</li>"
+  RELEASE_HTML="<ul><li>Bug fixes and improvements</li></ul>"
 else
   RELEASE_HTML=$(echo "$NOTES" | sed -E \
     -e 's/^### (.+)$/<h3>\1<\/h3>/' \
@@ -93,31 +68,35 @@ else
   ')
 fi
 
-DESCRIPTION_HTML="<body style=\"font-family: -apple-system, sans-serif; font-size: 13px; padding: 8px;\">${RELEASE_HTML}</body>"
+# Create HTML release notes files matching each archive name.
+# generate_appcast picks up <archive-name>.html automatically.
+for zip in "$STAGING"/TablePro-*.zip; do
+  basename="${zip%.zip}"
+  echo "$RELEASE_HTML" > "${basename}.html"
+done
 
 # ---------------------------------------------------------------------------
-# 5. Build appcast.xml — merge new items into existing feed
+# 4. Run generate_appcast
 # ---------------------------------------------------------------------------
 DOWNLOAD_PREFIX="${GITHUB_SERVER_URL:-https://github.com}/${GITHUB_REPOSITORY:-TableProApp/TablePro}/releases/download/v${VERSION}"
-PUB_DATE=$(date -u '+%a, %d %b %Y %H:%M:%S +0000')
-EXISTING_APPCAST="appcast.xml"
 
-mkdir -p appcast
+KEY_FILE=$(mktemp)
+# Override trap to clean up both
+trap 'rm -rf "$STAGING" "$KEY_FILE"' EXIT
+echo "$SPARKLE_PRIVATE_KEY" > "$KEY_FILE"
 
-python3 scripts/ci/update-appcast.py \
-  --output appcast/appcast.xml \
-  --existing "$EXISTING_APPCAST" \
-  --version "$SHORT_VERSION" \
-  --build "$BUILD_NUMBER" \
-  --min-os "$MIN_OS" \
-  --pub-date "$PUB_DATE" \
-  --description "$DESCRIPTION_HTML" \
-  --arm64-url "${DOWNLOAD_PREFIX}/TablePro-${VERSION}-arm64.zip" \
-  --arm64-length "$ARM64_LENGTH" \
-  --arm64-sig "$ARM64_ED_SIG" \
-  --x86-url "${DOWNLOAD_PREFIX}/TablePro-${VERSION}-x86_64.zip" \
-  --x86-length "$X86_64_LENGTH" \
-  --x86-sig "$X86_64_ED_SIG"
+"$SPARKLE_BIN/generate_appcast" \
+  --ed-key-file "$KEY_FILE" \
+  --download-url-prefix "$DOWNLOAD_PREFIX" \
+  --embed-release-notes \
+  --maximum-versions 0 \
+  "$STAGING"
+
+# ---------------------------------------------------------------------------
+# 5. Copy result
+# ---------------------------------------------------------------------------
+mkdir -p appcast
+cp "$STAGING/appcast.xml" appcast/appcast.xml
 
-echo "✅ Appcast generated:"
+echo "✅ Appcast generated by generate_appcast:"
 cat appcast/appcast.xml