Commit b396dfe
committed
fix: address review issues in NSUndoManager migration
- Fix primaryKeyChange undo closure capturing stale workingPrimaryKey
- Fix batch insertion undo leaking insertedRowData entries
- Clear undo history in loadSchema to prevent stale actions on table switch
- Make undoManager private to prevent bypass of lastUndoResult contract1 parent 7110b84 commit b396dfe
2 files changed
Lines changed: 6 additions & 3 deletions
File tree
- TablePro/Core
- ChangeTracking
- SchemaTracking
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
| 101 | + | |
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| |||
606 | 606 | | |
607 | 607 | | |
608 | 608 | | |
| 609 | + | |
609 | 610 | | |
610 | 611 | | |
611 | 612 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
99 | | - | |
| 99 | + | |
100 | 100 | | |
101 | 101 | | |
| 102 | + | |
102 | 103 | | |
103 | 104 | | |
104 | 105 | | |
| |||
673 | 674 | | |
674 | 675 | | |
675 | 676 | | |
| 677 | + | |
676 | 678 | | |
677 | | - | |
| 679 | + | |
678 | 680 | | |
679 | 681 | | |
680 | 682 | | |
| |||
0 commit comments