fix: resolve SSH tunnel relay deadlock and provisioning conflicts

datlechin · datlechin · commit cd65d9ed60ad · 2026-03-16T09:11:55.000+07:00
- Make SSH relay queue concurrent to prevent forwarding loop from blocking data relay
- Clear PROVISIONING_PROFILE_SPECIFIER from pbxproj for local automatic signing
- Pass provisioning profile as CLI override in build-release.sh for CI
- Include libssh2 error detail in public key auth failure messages
diff --git a/TablePro.xcodeproj/project.pbxproj b/TablePro.xcodeproj/project.pbxproj
@@ -1704,7 +1704,7 @@
 				);
 				PRODUCT_BUNDLE_IDENTIFIER = com.TablePro;
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				PROVISIONING_PROFILE_SPECIFIER = "TablePro Developer ID";
+				PROVISIONING_PROFILE_SPECIFIER = "";
 				REGISTER_APP_GROUPS = YES;
 				RUNTIME_EXCEPTION_ALLOW_DYLD_ENVIRONMENT_VARIABLES = NO;
 				RUNTIME_EXCEPTION_ALLOW_JIT = NO;
@@ -1735,7 +1735,7 @@
 				AUTOMATION_APPLE_EVENTS = NO;
 				CODE_SIGN_ENTITLEMENTS = TablePro/TablePro.entitlements;
 				CODE_SIGN_IDENTITY = "Apple Development";
-				"CODE_SIGN_IDENTITY[sdk=macosx*]" = "-";
+				"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development";
 				CODE_SIGN_STYLE = Automatic;
 				COPY_PHASE_STRIP = YES;
 				CURRENT_PROJECT_VERSION = 34;
@@ -1777,7 +1777,7 @@
 				);
 				PRODUCT_BUNDLE_IDENTIFIER = com.TablePro;
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				PROVISIONING_PROFILE_SPECIFIER = "TablePro Developer ID";
+				PROVISIONING_PROFILE_SPECIFIER = "";
 				REGISTER_APP_GROUPS = YES;
 				RUNTIME_EXCEPTION_ALLOW_DYLD_ENVIRONMENT_VARIABLES = NO;
 				RUNTIME_EXCEPTION_ALLOW_JIT = NO;
diff --git a/TablePro.xcodeproj/xcshareddata/xcschemes/TablePro.xcscheme b/TablePro.xcodeproj/xcshareddata/xcschemes/TablePro.xcscheme
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
    LastUpgradeVersion = "2640"
-   version = "1.7">
+   version = "1.8">
    <BuildAction
       parallelizeBuildables = "YES"
       buildImplicitDependencies = "YES"
diff --git a/TablePro/Core/SSH/Auth/PublicKeyAuthenticator.swift b/TablePro/Core/SSH/Auth/PublicKeyAuthenticator.swift
@@ -50,7 +50,13 @@ internal struct PublicKeyAuthenticator: SSHAuthenticator {
         }
 
         guard rc == 0 else {
-            throw SSHTunnelError.authenticationFailed
+            var msgPtr: UnsafeMutablePointer<CChar>?
+            var msgLen: Int32 = 0
+            libssh2_session_last_error(session, &msgPtr, &msgLen, 0)
+            let detail = msgPtr.map { String(cString: $0) } ?? "Unknown error"
+            throw SSHTunnelError.tunnelCreationFailed(
+                "Public key authentication failed: \(detail)"
+            )
         }
     }
 }
diff --git a/TablePro/Core/SSH/LibSSH2Tunnel.swift b/TablePro/Core/SSH/LibSSH2Tunnel.swift
@@ -34,7 +34,8 @@ internal final class LibSSH2Tunnel: @unchecked Sendable {
     /// Keeps blocking work off the Swift cooperative thread pool.
     private static let relayQueue = DispatchQueue(
         label: "com.TablePro.ssh.relay",
-        qos: .utility
+        qos: .utility,
+        attributes: .concurrent
     )
 
     /// Callback invoked when the tunnel dies (keep-alive failure, etc.)
diff --git a/TablePro/Resources/Localizable.xcstrings b/TablePro/Resources/Localizable.xcstrings
@@ -5465,6 +5465,9 @@
           }
         }
       }
+    },
+    "Database Index" : {
+
     },
     "Database Index: %lld" : {
       "extractionState" : "stale",
@@ -19042,7 +19045,6 @@
       }
     },
     "Use ~/.pgpass" : {
-      "extractionState" : "stale",
       "localizations" : {
         "vi" : {
           "stringUnit" : {
diff --git a/scripts/build-release.sh b/scripts/build-release.sh
@@ -347,6 +347,7 @@ build_for_arch() {
         CODE_SIGN_IDENTITY="$SIGN_IDENTITY" \
         CODE_SIGN_STYLE=Manual \
         DEVELOPMENT_TEAM="$TEAM_ID" \
+        PROVISIONING_PROFILE_SPECIFIER="TablePro Developer ID" \
         ${ANALYTICS_HMAC_SECRET:+ANALYTICS_HMAC_SECRET="$ANALYTICS_HMAC_SECRET"} \
         -skipPackagePluginValidation \
         -clonedSourcePackagesDirPath "$SPM_CACHE_DIR" \

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,13 @@ internal struct PublicKeyAuthenticator: SSHAuthenticator {`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`guard rc == 0 else {`
`53`		`- throw SSHTunnelError.authenticationFailed`
	`53`	`+ var msgPtr: UnsafeMutablePointer<CChar>?`
	`54`	`+ var msgLen: Int32 = 0`
	`55`	`+ libssh2_session_last_error(session, &msgPtr, &msgLen, 0)`
	`56`	`+ let detail = msgPtr.map { String(cString: $0) } ?? "Unknown error"`
	`57`	`+ throw SSHTunnelError.tunnelCreationFailed(`
	`58`	`+ "Public key authentication failed: \(detail)"`
	`59`	`+ )`
`54`	`60`	`}`
`55`	`61`	`}`
`56`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,8 @@ internal final class LibSSH2Tunnel: @unchecked Sendable {`
`34`	`34`	`/// Keeps blocking work off the Swift cooperative thread pool.`
`35`	`35`	`private static let relayQueue = DispatchQueue(`
`36`	`36`	`label: "com.TablePro.ssh.relay",`
`37`		`- qos: .utility`
	`37`	`+ qos: .utility,`
	`38`	`+ attributes: .concurrent`
`38`	`39`	`)`
`39`	`40`
`40`	`41`	`/// Callback invoked when the tunnel dies (keep-alive failure, etc.)`
Original file line number	Diff line number	Diff line change
`@@ -5465,6 +5465,9 @@`
`5465`	`5465`	`}`
`5466`	`5466`	`}`
`5467`	`5467`	`}`
	`5468`	`+ },`
	`5469`	`+ "Database Index" : {`
	`5470`	`+`
`5468`	`5471`	`},`
`5469`	`5472`	`"Database Index: %lld" : {`
`5470`	`5473`	`"extractionState" : "stale",`
`@@ -19042,7 +19045,6 @@`
`19042`	`19045`	`}`
`19043`	`19046`	`},`
`19044`	`19047`	`"Use ~/.pgpass" : {`
`19045`		`- "extractionState" : "stale",`
`19046`	`19048`	`"localizations" : {`
`19047`	`19049`	`"vi" : {`
`19048`	`19050`	`"stringUnit" : {`