Skip to content

Commit e1687aa

Browse files
committed
fix: remove groupsByEvent=false — causes registerUndo to silently fail
With groupsByEvent=false, NSUndoManager requires explicit beginUndoGrouping() before registerUndo(). Without it, registerUndo throws an exception that AppKit catches silently, causing all undo registration to be no-ops. This broke cell edit commit — changes were recorded in the tracking arrays but never registered with the undo manager. The default groupsByEvent=true auto-creates groups per run loop pass, which is correct for individual cell edits.
1 parent 4a752bd commit e1687aa

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

TablePro/Core/ChangeTracking/DataChangeManager.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ final class DataChangeManager {
101101
private let undoManager: UndoManager = {
102102
let manager = UndoManager()
103103
manager.levelsOfUndo = 100
104-
manager.groupsByEvent = false
105104
return manager
106105
}()
107106

0 commit comments

Comments
 (0)