Skip to content

Commit fb53f58

Browse files
committed
revert: remove skeleton loading views per user feedback
1 parent 56e0347 commit fb53f58

4 files changed

Lines changed: 19 additions & 42 deletions

File tree

CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
99

1010
### Added
1111

12-
- Skeleton loading placeholder in data grid and structure views during initial load
1312
- Per-connection "Local only" option to exclude individual connections from iCloud sync
1413
- Filter operator picker shows SQL symbols alongside names for quick visual recognition
1514
- SQL autocomplete now suggests column names before a FROM clause is written, using all cached schema columns as fallback

TablePro/Views/Components/DataGridSkeletonView.swift

Lines changed: 0 additions & 16 deletions
This file was deleted.

TablePro/Views/Main/Child/MainEditorContentView.swift

Lines changed: 19 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -415,30 +415,26 @@ struct MainEditorContentView: View {
415415
)
416416
}
417417
} else {
418-
if tab.isExecuting && tab.resultColumns.isEmpty && tab.lastExecutedAt == nil {
419-
DataGridSkeletonView()
420-
} else {
421-
// Filter panel (collapsible, above data grid)
422-
if filterStateManager.isVisible && tab.tabType == .table {
423-
FilterPanelView(
424-
filterState: filterStateManager,
425-
columns: tab.resultColumns,
426-
primaryKeyColumn: changeManager.primaryKeyColumn,
427-
databaseType: connection.type,
428-
onApply: onApplyFilters,
429-
onUnset: onClearFilters
430-
)
431-
Divider()
432-
}
418+
// Filter panel (collapsible, above data grid)
419+
if filterStateManager.isVisible && tab.tabType == .table {
420+
FilterPanelView(
421+
filterState: filterStateManager,
422+
columns: tab.resultColumns,
423+
primaryKeyColumn: changeManager.primaryKeyColumn,
424+
databaseType: connection.type,
425+
onApply: onApplyFilters,
426+
onUnset: onClearFilters
427+
)
428+
Divider()
429+
}
433430

434-
if tab.tabType == .query && !tab.resultColumns.isEmpty
435-
&& tab.resultRows.isEmpty && tab.lastExecutedAt != nil
436-
&& !tab.isExecuting && !filterStateManager.hasAppliedFilters
437-
{
438-
emptyResultView(executionTime: tab.activeResultSet?.executionTime ?? tab.executionTime)
439-
} else {
440-
dataGridView(tab: tab)
441-
}
431+
if tab.tabType == .query && !tab.resultColumns.isEmpty
432+
&& tab.resultRows.isEmpty && tab.lastExecutedAt != nil
433+
&& !tab.isExecuting && !filterStateManager.hasAppliedFilters
434+
{
435+
emptyResultView(executionTime: tab.activeResultSet?.executionTime ?? tab.executionTime)
436+
} else {
437+
dataGridView(tab: tab)
442438
}
443439
}
444440
}

TablePro/Views/Structure/TableStructureView.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,8 +178,6 @@ struct TableStructureView: View {
178178
private var contentArea: some View {
179179
if let error = errorMessage {
180180
errorView(error)
181-
} else if isInitialLoading {
182-
DataGridSkeletonView()
183181
} else {
184182
tabContent
185183
}

0 commit comments

Comments
 (0)