Skip to content

cleanup: remove all dead AppState.shared writes and delete AppState class#613

Merged
datlechin merged 1 commit intomainfrom
cleanup/remove-dead-appstate-writes
Apr 7, 2026
Merged

cleanup: remove all dead AppState.shared writes and delete AppState class#613
datlechin merged 1 commit intomainfrom
cleanup/remove-dead-appstate-writes

Conversation

@datlechin
Copy link
Copy Markdown
Member

Summary

Removes all 51 dead AppState.shared write statements and deletes the AppState class definition. After PR #610 migrated all reads to @FocusedValue, these writes had zero readers.

11 files, -94 lines:

  • TableProApp.swift — deleted AppState class (15 lines)
  • ContentView.swift — removed 22 writes (connection state push on session/key window changes)
  • MainContentCoordinator+Navigation.swift — removed 7 writes
  • MainContentView+EventHandlers.swift — removed 4 writes
  • MainContentCoordinator+TabSwitch.swift — removed 4 writes
  • TableStructureView.swift — removed 4 writes
  • MainContentCoordinator+FKNavigation.swift — removed 2 writes
  • MainContentCoordinator+QueryHelpers.swift — removed 2 writes
  • MainContentView.swift — removed 1 write
  • MainEditorContentView.swift — removed 1 write
  • TableStructureView+DataLoading.swift — removed 1 write

grep -rn "AppState" TablePro/ --include='*.swift' returns zero results.

Test plan

  • Build succeeds
  • All menu items still enable/disable correctly
  • Multi-window: menus reflect active window

…lass

Removed 51 dead write statements across 10 files and deleted the
AppState class definition. Zero AppState references remain.
@datlechin datlechin merged commit ce1a93d into main Apr 7, 2026
2 checks passed
@datlechin datlechin deleted the cleanup/remove-dead-appstate-writes branch April 7, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant