fix: prevent crash when opening Oracle views with LONG columns#614
Closed
fix: prevent crash when opening Oracle views with LONG columns#614
Conversation
OracleNIO crashes (EXC_BREAKPOINT) when decoding LONG/LONG RAW column data. Detect SELECT * queries, pre-fetch column metadata, and replace * with explicit columns excluding unsafe types. Closes #564
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EXC_BREAKPOINTinOracleBackendMessageDecoder.decodewhen decoding LONG/LONG RAW column data — this is an unrecoverable precondition failureSELECT *queries inOraclePlugin.execute(), pre-fetch column metadata fromALL_TAB_COLUMNS, and rewrite to an explicit column list replacing LONG/LONG RAW withNULL AS "col"buildBrowseQuery/buildFilteredQueryalso exclude them on subsequent pagination/sorting/filtering*queriesCloses #564
Test plan
gvenzl/oracle-freecontainer)ALL_VIEWS,ALL_TAB_COLUMNS) — should open without crash