Conversation
…rdering, storage thread safety
89bea8b to
71199cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 4 ship-blocking bugs found during AI system audit:
suggestionOffsetwas set afterfetchSuggestion()returned, butshowGhostTextwas called during streaming using the stale value. Fix: set offset before the await.acceptSuggestion()was deferred viaTask { @MainActor }to the next runloop tick, buthandleTextChange()fired synchronously first and clearedcurrentSuggestion. Fix: callacceptSuggestion()synchronously (already insideMainActor.assumeIsolated).trimMessagesIfNeeded()could leave the conversation starting with an assistant message after removing oldest messages, causing Anthropic API 400 errors ("messages must start with user role"). Fix: drop leading assistant messages after trim.AIChatStoragewas a plainfinal classwith no isolation.loadAll()ran on a detached thread whilesave()/delete()ran on MainActor — concurrent file I/O on the same directory. Fix: convert toactor, update all callers toawait, rewritedeleteAll()to enumerate files instead of removing the directory.Test plan