Skip to content

refactor: restructure settings window with native macOS patterns#829

Merged
datlechin merged 2 commits into
mainfrom
refactor/settings-native-macos
Apr 22, 2026
Merged

refactor: restructure settings window with native macOS patterns#829
datlechin merged 2 commits into
mainfrom
refactor/settings-native-macos

Conversation

@datlechin
Copy link
Copy Markdown
Member

Summary

  • Consolidate 12 settings tabs into 8 (General, Appearance, Editor, Keyboard, AI, Terminal, Plugins, Account)
  • Extract section components into Settings/Sections/ — thin tab composers + self-contained sections
  • Fix native macOS anti-patterns: HStackLabeledContent, inline Text(.caption).help() tooltips and Section(footer:), segmented picker → popup menu inside Form
  • Remove dead EditorSettings.autoIndent (stored but never consumed by editor)
  • Wire dead MCP settings (defaultRowLimit, maxRowLimit, queryTimeoutSeconds) to MCPToolHandler
  • Reorder fields: most-used first, destructive actions last
  • Clean up stale iOS project references to deleted files

Test plan

  • Open Settings, navigate all 8 tabs — verify layout, no regressions
  • Appearance tab: theme list + editor display correctly, mode picker works
  • Editor tab: verify autoIndent toggle is gone, data grid settings work
  • Terminal tab: MCP section renders correctly, enable/disable works
  • Account tab: license info + sync toggles + linked folders all functional
  • Hover over converted controls — verify .help() tooltips appear
  • MCP: change default row limit in settings → query via MCP → verify new default applies

@datlechin datlechin merged commit 9dd0eb4 into main Apr 22, 2026
2 checks passed
@datlechin datlechin deleted the refactor/settings-native-macos branch April 22, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant