refactor: replace hacks with native macOS patterns and clean up concurrency#830
Merged
Conversation
…rrency - Toolbar: replace opacity/hitTesting hacks with conditional rendering for database switcher, import button, and results button; merge connection + database into single toolbar item group - Toolbar: hide "Switch Database" hint in empty state for non-switching databases - SSH: replace DispatchSemaphore blocking with DispatchQueue.main.sync in PromptPassphraseProvider and PromptTOTPProvider - Terminal: replace @State NSObjectProtocol observer with .task async notification stream for tunnel waiting - Concurrency: remove redundant Task { @mainactor in } across 28 files where enclosing type is already @mainactor; keep @mainactor in @sendable closures - Replace DispatchQueue.main.asyncAfter with Task.sleep in MCPSection and FavoritesSidebarViewModel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.opacity()/.allowsHitTesting()hacks with conditionalifrendering for database switcher, import button, and results button. Merge connection + database into a single toolbar item group so non-switching databases (libSQL, SQLite, Redis) show no gap. Hide "Switch Database" hint in empty state for non-switching databases.DispatchSemaphoreblocking pattern withDispatchQueue.main.syncinPromptPassphraseProviderandPromptTOTPProvider— same semantics, no thread waste.@State NSObjectProtocol?observer with.taskusingNotificationCenter.default.notifications(named:)async stream for SSH tunnel waiting — auto-cancelled on view disappear, no manual lifecycle.Task { @MainActor in }across 28 files where the enclosing type is already@MainActor. Keep@MainActorannotation in@Sendableclosure contexts (NotificationCenter callbacks, KVO observers, DispatchSource handlers, Timer blocks).DispatchQueue.main.asyncAfterwithTask.sleepin MCPSection (copy confirmation) and FavoritesSidebarViewModel (folder rename delay).Test plan