Conversation
…ting helper resolvedTableRowsForTab(coordinator:tabId:) and resolvedTableRows(for:) returned the same one-liner: coordinator.tableRowsStore.existingTableRows(for: id) ?? TableRows(). The duplicate existed because the dataGridView closure captures [coordinator] and didn't have a QueryTab in scope. Inlined the store read directly in the closure (already a one-liner, no helper needed). Drops the duplicate method. resolvedTableRows(for tab:) stays for the four other call sites that operate on a QueryTab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops the duplicate
resolvedTableRowsForTab(coordinator:tabId:)helper inMainEditorContentView. Both helpers returned the same one-liner — the duplicate existed because thedataGridViewclosure captures[coordinator]and didn't have aQueryTabin scope.Inlined the store read directly in the closure (already a one-liner, no helper needed).
resolvedTableRows(for tab:)stays for the four other call sites that operate on aQueryTab.Test plan
Net −5 LOC. One less duplicate.