fix(mysql): route view DDL through text protocol (#390)

create_view, alter_view and drop_view executed their statements via
sqlx::query(), which uses MySQL's prepared-statement protocol. MySQL
rejects CREATE VIEW / ALTER VIEW there with error 1295 ("This command
is not supported in the prepared statement protocol yet"), so saving a
view from the view editor failed.

Route all three through sqlx::raw_sql() (COM_QUERY text protocol),
matching the existing handling for transaction-control statements.

Co-authored-by: Daniel Noé Núñez López <daniel.nunez@stjsonora.gob.mx>
Co-authored-by: Andrea Debernardi <andrea@debbaweb.it>

Author: 3 people

src-tauri/src/drivers/mysql/mod.rs

@@ -935,7 +935,8 @@ pub async fn create_view(
     let text = resolve_text_proto(&pool, params).await?;
     let escaped_name = escape_identifier(view_name);
     let query = format!("CREATE VIEW `{}` AS {}", escaped_name, definition);
-    exec_stmt(&pool, text, &query)
+    sqlx::raw_sql(&query)
+        .execute(&pool)
         .await
         .map_err(|e| format!("Failed to create view: {}", e))?;
     Ok(())
@@ -950,7 +951,11 @@ pub async fn alter_view(
     let text = resolve_text_proto(&pool, params).await?;
     let escaped_name = escape_identifier(view_name);
     let query = format!("ALTER VIEW `{}` AS {}", escaped_name, definition);
-    exec_stmt(&pool, text, &query)
+    // `ALTER VIEW` is not supported by MySQL's prepared-statement protocol
+    // (server error 1295), so it must go through `raw_sql()` (text protocol)
+    // rather than `sqlx::query()`. See `is_text_protocol_stmt` for context.
+    sqlx::raw_sql(&query)
+        .execute(&pool)
         .await
         .map_err(|e| format!("Failed to alter view: {}", e))?;
     Ok(())
@@ -961,7 +966,11 @@ pub async fn drop_view(params: &ConnectionParams, view_name: &str) -> Result<(),
     let text = resolve_text_proto(&pool, params).await?;
     let escaped_name = escape_identifier(view_name);
     let query = format!("DROP VIEW IF EXISTS `{}`", escaped_name);
-    exec_stmt(&pool, text, &query)
+    // Routed through `raw_sql()` (text protocol) for consistency with
+    // create/alter view, which the prepared-statement protocol rejects
+    // with server error 1295.
+    sqlx::raw_sql(&query)
+        .execute(&pool)
         .await
         .map_err(|e| format!("Failed to drop view: {}", e))?;
     Ok(())