fix: transaction status lost for captured commiting exception

Author: tomaszmalik

src/TagBites.DB/DB/DbLinkContext.cs

@@ -813,30 +813,37 @@ internal void MarkTransaction(bool rollback, bool rollbackCalled = false)
                             try
                             {
                                 OnTransactionBeforeCommit();
-                                _batchQueue.Flush();
+
+                                if (_transactionContext.Status != DbLinkTransactionStatus.RollingBack)
+                                    _batchQueue.Flush();
+                                else
+                                    _batchQueue.Cancel();
                             }
                             catch
                             {
                                 _transactionContext.Status = DbLinkTransactionStatus.RollingBack;
                                 throw;
                             }
 
-                        if (_transactionContext.DbTransactionInternal != null)
-                            try
-                            {
-                                _transactionContext.DbTransactionInternal.Commit();
-                            }
-                            catch (Exception e)
-                            {
-                                _transactionContext.Status = DbLinkTransactionStatus.RollingBack;
+                        if (_transactionContext.Status != DbLinkTransactionStatus.RollingBack)
+                        {
+                            if (_transactionContext.DbTransactionInternal != null)
+                                try
+                                {
+                                    _transactionContext.DbTransactionInternal.Commit();
+                                }
+                                catch (Exception e)
+                                {
+                                    _transactionContext.Status = DbLinkTransactionStatus.RollingBack;
 
-                                var ex = OnFormatException(e);
-                                if (e == ex)
-                                    throw;
-                                throw ex;
-                            }
+                                    var ex = OnFormatException(e);
+                                    if (e == ex)
+                                        throw;
+                                    throw ex;
+                                }
 
-                        _transactionContext.Status = DbLinkTransactionStatus.Committing;
+                            _transactionContext.Status = DbLinkTransactionStatus.Committing;
+                        }
                     }
                 }
                 // Rollback
@@ -1267,7 +1274,18 @@ protected virtual Exception OnFormatException(Exception e)
         }
         protected virtual void OnTransactionBeforeCommit()
         {
-            _transactionCommiting?.Invoke(this, EventArgs.Empty);
+            if (_transactionCommiting?.GetInvocationList() is { } events)
+            {
+                // ReSharper disable once ForCanBeConvertedToForeach
+                for (var i = 0; i < events.Length; i++)
+                {
+                    var action = (EventHandler)events[i];
+                    action(this, EventArgs.Empty);
+
+                    if (_transactionContext.Status == DbLinkTransactionStatus.RollingBack)
+                        break;
+                }
+            }
         }
 
         protected virtual void OnConnectionCreated() { }

src/TagBites.DB/DB/DbLinkTransactionContext.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Data.Common;
 
 namespace TagBites.DB
@@ -219,7 +219,21 @@ protected void CheckDispose()
 
         private void OnTransactionBeginning(object sender, EventArgs e) => _transactionBeginning?.Invoke(this, e);
         private void OnTransactionBegan(object sender, EventArgs e) => _transactionBegan?.Invoke(this, e);
-        private void OnTransactionCommiting(object sender, EventArgs e) => _transactionCommiting?.Invoke(this, e);
+        private void OnTransactionCommiting(object sender, EventArgs e)
+        {
+            if (_transactionCommiting?.GetInvocationList() is { } events)
+            {
+                // ReSharper disable once ForCanBeConvertedToForeach
+                for (var i = 0; i < events.Length; i++)
+                {
+                    var action = (EventHandler)events[i];
+                    action(this, EventArgs.Empty);
+
+                    if (Status == DbLinkTransactionStatus.RollingBack)
+                        break;
+                }
+            }
+        }
         private void OnTransactionClosed(object sender, DbLinkTransactionCloseEventArgs e) => _transactionClosed?.Invoke(this, e);
         private void OnTransactionContextClosed(object sender, DbLinkTransactionContextCloseEventArgs e) => _transactionContextClosed?.Invoke(this, e);
     }

tests/TagBites.DB.Tests/DB/TransactionTests.cs

@@ -126,7 +126,8 @@ void OnConnectionContextOnTransactionContextClose(object s, DbLinkTransactionCon
                         transaction2.Commit();
                     }
                 }
-            };
+            }
+            ;
 
             Assert.Equal(1, count1);
             Assert.Equal(1, count2);
@@ -199,5 +200,57 @@ public void BeforeCommitTest()
                 Assert.Equal(0, close);
             }
         }
+
+        [Fact]
+        public void ErrorOnCommittingTest()
+        {
+            using var link = DefaultProvider.CreateLink();
+
+            using (var t = link.Begin())
+            {
+                link.Force();
+
+                link.TransactionContext.TransactionCommiting += (obj, args) =>
+                {
+                    using var l = DefaultProvider.CreateLink();
+
+                    Assert.Equal(DbLinkTransactionStatus.Open, l.TransactionStatus);
+
+                    try
+                    {
+                        l.ExecuteNonQuery("DO $$ BEGIN RAISE EXCEPTION 'error'; END; $$;");
+                    }
+                    catch
+                    {
+                        // ignored
+                    }
+
+                    Assert.Equal(DbLinkTransactionStatus.RollingBack, l.TransactionStatus);
+                };
+
+                link.TransactionContext.TransactionClosed += (obj, args) =>
+                {
+                    Assert.Equal(DbLinkTransactionCloseReason.Rollback, args.CloseReason);
+                };
+                link.TransactionContext.TransactionContextClosed += (obj, args) =>
+                {
+                    Assert.Equal(DbLinkTransactionCloseReason.Rollback, args.CloseReason);
+                };
+
+                try
+                {
+                    t.Commit();
+                }
+                catch
+                {
+                    // ignored
+                }
+
+                Assert.Equal(DbLinkTransactionStatus.RollingBack, link.TransactionStatus);
+            }
+
+            Assert.Equal(DbLinkTransactionStatus.None, link.TransactionStatus);
+            link.ExecuteScalar("SELECT 1");
+        }
     }
 }