feat: move transaction close events after lock

Author: tomaszmalik

src/TagBites.DB/DB/DbLinkContext.cs

@@ -783,7 +783,8 @@ private void SystemTransactionCompleted(object sender, TransactionEventArgs e)
                     }
                     finally
                     {
-                        CloseTransaction(0);
+                        var closeEvents = CloseTransaction(0);
+                        closeEvents();
                     }
                 }
                 finally
@@ -870,7 +871,7 @@ internal void MarkTransaction(bool rollback, bool rollbackCalled = false)
                 }
             }
         }
-        internal void CloseTransaction(int level)
+        internal Action CloseTransaction(int level)
         {
             Exception ex = null;
             Action closeTransactionEvent = null;
@@ -933,32 +934,35 @@ internal void CloseTransaction(int level)
                     _transactionContext.Status = DbLinkTransactionStatus.None;
                     _transactionContext.ForceRelease();
                     _transactionContext = null;
+                }
+            }
 
-                    // Transaction Closed
-                    try
-                    {
-                        closeTransactionEvent?.Invoke();
-                    }
-                    catch (Exception ex2)
-                    {
-                        ex = ToAggregateException("Exception occurred while executing TransactionClose event.", ex, ex2);
-                    }
+            return () =>
+            {
+                // Transaction Closed
+                try
+                {
+                    closeTransactionEvent?.Invoke();
+                }
+                catch (Exception ex2)
+                {
+                    ex = ToAggregateException("Exception occurred while executing TransactionClose event.", ex, ex2);
+                }
 
-                    // Transaction Context Closed
-                    try
-                    {
-                        closeTransactionContextEvent?.Invoke();
-                    }
-                    catch (Exception ex2)
-                    {
-                        ex = ToAggregateException("Exception occurred while executing TransactionContextClose event.", ex, ex2);
-                    }
+                // Transaction Context Closed
+                try
+                {
+                    closeTransactionContextEvent?.Invoke();
+                }
+                catch (Exception ex2)
+                {
+                    ex = ToAggregateException("Exception occurred while executing TransactionContextClose event.", ex, ex2);
                 }
 
                 // Throw exception
                 if (ex != null)
                     throw ex;
-            }
+            };
         }
 
         private T ExecuteInner<T>(IQuerySource source, ExecuteQueryWithRowCountDelegate<T> action)

src/TagBites.DB/DB/DbLinkTransaction.cs

@@ -57,6 +57,7 @@ private void CloseTransaction(bool rollback)
         public void Dispose()
         {
             GC.SuppressFinalize(this);
+            Action closeEvents = null;
 
             lock (_locker)
             {
@@ -77,7 +78,7 @@ public void Dispose()
                             }
                             finally
                             {
-                                _context.CloseTransaction(_nestingLevel);
+                                closeEvents = _context.CloseTransaction(_nestingLevel);
                             }
                     }
                     finally
@@ -86,6 +87,8 @@ public void Dispose()
                     }
                 }
             }
+
+            closeEvents?.Invoke();
         }
     }
 }

src/TagBites.DB/DB/DbLinkTransactionWithScope.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Diagnostics;
 using System.Transactions;
 using TagBites.Utils;
@@ -77,7 +77,8 @@ public void Dispose()
                 if (m_transactionScope != null)
                     try
                     {
-                        m_context.CloseTransaction(m_nestingLevel);
+                        var closeEvents = m_context.CloseTransaction(m_nestingLevel);
+                        closeEvents();
                     }
                     finally
                     {