Skip to content

HTM-1964: Add GeoJSON extract format#1702

Merged
mprins merged 1 commit into
HTM-1960_Custom_extract_functionality_for_layer_attributesfrom
HTM-1964_geojson_extractor
Apr 23, 2026
Merged

HTM-1964: Add GeoJSON extract format#1702
mprins merged 1 commit into
HTM-1960_Custom_extract_functionality_for_layer_attributesfrom
HTM-1964_geojson_extractor

Conversation

@mprins
Copy link
Copy Markdown
Contributor

@mprins mprins commented Apr 21, 2026

@mprins mprins self-assigned this Apr 21, 2026
@mprins mprins added the enhancement New feature or request label Apr 21, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 2 package(s) with unknown licenses.
See the Details below.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 9042324.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

License Issues

pom.xml

PackageVersionLicenseIssue Type
org.geotools:gt-bom35-SNAPSHOTNullUnknown License
org.geotools:gt-geojson-storeNullUnknown License
Allowed Licenses: MIT, Apache-2.0, BSD-2-Clause, BSD-3-Clause, ISC, MPL-2.0, LGPL-2.1-only, EPL-2.0, EPL-1.0
Excluded from license check: pkg:maven/org.eclipse.angus/jakarta.mail@2.0.5?type=jar, pkg:maven/jakarta.ws.rs:jakarta.ws.rs-api@4.0.0?type=jar

OpenSSF Scorecard

PackageVersionScoreDetails
maven/org.geotools:gt-bom 35-SNAPSHOT UnknownUnknown
maven/org.geotools:gt-geojson-store UnknownUnknown

Scanned Files

  • pom.xml

@mprins mprins changed the title HTM-1964: Add GeoJSON extract format [WIP] HTM-1964: Add GeoJSON extract format Apr 21, 2026
@mprins mprins marked this pull request as ready for review April 21, 2026 12:00
@mprins mprins requested review from a team, Copilot and matthijsln April 21, 2026 12:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds initial support for exporting layer extracts as GeoJSON in the Tailormap API extract pipeline (controller/service + integration test), including a GeoTools GeoJSON store dependency.

Changes:

  • Add GeoJSON extract handling via GeoJSONDataStoreFactory in CreateLayerExtractService.
  • Update extract output filename extension for GeoJSON to .geojson.
  • Add an integration test that exercises GeoJSON extract creation + download + basic GeoJSON structure assertions.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
src/main/java/org/tailormap/api/service/CreateLayerExtractService.java Adds GeoJSON datastore creation and notes GeoTools workaround considerations.
src/main/java/org/tailormap/api/controller/LayerExtractController.java Changes GeoJSON extension from json to geojson.
src/test/java/org/tailormap/api/controller/LayerExtractControllerIntegrationTest.java Adds GeoJSON extract integration test and JSONPath assertions.
pom.xml Adds org.geotools:gt-geojson-store dependency.

Comment thread pom.xml
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ilormap/api/service/CreateLayerExtractService.java 84% 1 Missing ⚠️

Impacted file tree graph

@@                                     Coverage Diff                                      @@
##             HTM-1960_Custom_extract_functionality_for_layer_attributes   #1702   +/-   ##
============================================================================================
- Coverage                                                            77%     77%   -0%     
  Complexity                                                          136     136           
============================================================================================
  Files                                                               161     161           
  Lines                                                              8120    8123    +3     
  Branches                                                            757     757           
============================================================================================
+ Hits                                                               6226    6228    +2     
- Misses                                                             1451    1452    +1     
  Partials                                                            443     443           
Files with missing lines Coverage Δ Complexity Δ
...ilormap/api/controller/LayerExtractController.java 68% <100%> (ø) 0 <0> (ø)
...ilormap/api/service/CreateLayerExtractService.java 56% <84%> (+1%) 0 <0> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Test Results

491 tests  +1   490 ✅ +1   7m 42s ⏱️ -9s
 58 suites ±0     1 💤 ±0 
 58 files   ±0     0 ❌ ±0 

Results for commit 9042324. ± Comparison against base commit e6a4eb8.

♻️ This comment has been updated with latest results.

@mprins mprins force-pushed the HTM-1964_geojson_extractor branch 3 times, most recently from 59ebd49 to b348fa6 Compare April 21, 2026 15:10
@mprins mprins force-pushed the HTM-1960_Custom_extract_functionality_for_layer_attributes branch from 340392d to e6a4eb8 Compare April 23, 2026 09:25
@mprins mprins force-pushed the HTM-1964_geojson_extractor branch from 22efd3e to 4560e54 Compare April 23, 2026 09:35
@mprins mprins changed the title [WIP] HTM-1964: Add GeoJSON extract format HTM-1964: Add GeoJSON extract format Apr 23, 2026
For now use GeoTools 35-SNAPSHOT to make geojson export work, see https://osgeo-org.atlassian.net/browse/GEOT-7894
@mprins mprins force-pushed the HTM-1964_geojson_extractor branch from 6d16394 to 9042324 Compare April 23, 2026 09:49
@mprins mprins merged commit a66c1a0 into HTM-1960_Custom_extract_functionality_for_layer_attributes Apr 23, 2026
20 checks passed
@mprins mprins deleted the HTM-1964_geojson_extractor branch April 23, 2026 11:07
mprins added a commit that referenced this pull request Apr 24, 2026
For now use GeoTools 35-SNAPSHOT to make geojson export work, see https://osgeo-org.atlassian.net/browse/GEOT-7894
mprins added a commit that referenced this pull request Apr 28, 2026
For now use GeoTools 35-SNAPSHOT to make geojson export work, see https://osgeo-org.atlassian.net/browse/GEOT-7894
mprins added a commit that referenced this pull request Apr 28, 2026
For now use GeoTools 35-SNAPSHOT to make geojson export work, see https://osgeo-org.atlassian.net/browse/GEOT-7894
mprins added a commit that referenced this pull request Apr 29, 2026
For now use GeoTools 35-SNAPSHOT to make geojson export work, see https://osgeo-org.atlassian.net/browse/GEOT-7894
mprins added a commit that referenced this pull request May 5, 2026
For now use GeoTools 35-SNAPSHOT to make geojson export work, see https://osgeo-org.atlassian.net/browse/GEOT-7894
mprins added a commit that referenced this pull request May 5, 2026
For now use GeoTools 35-SNAPSHOT to make geojson export work, see https://osgeo-org.atlassian.net/browse/GEOT-7894
mprins added a commit that referenced this pull request May 8, 2026
For now use GeoTools 35-SNAPSHOT to make geojson export work, see https://osgeo-org.atlassian.net/browse/GEOT-7894
mprins added a commit that referenced this pull request May 11, 2026
For now use GeoTools 35-SNAPSHOT to make geojson export work, see https://osgeo-org.atlassian.net/browse/GEOT-7894
mprins added a commit that referenced this pull request May 12, 2026
For now use GeoTools 35-SNAPSHOT to make geojson export work, see https://osgeo-org.atlassian.net/browse/GEOT-7894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants