Skip to content

HTM-2016: Create a separate SseEventBus bean for the viewer so viewers don't get administrative broadcasts#1728

Merged
mprins merged 1 commit into
HTM-1960_Custom_extract_functionality_for_layer_attributesfrom
HTM-2016_prevent_leaking_admin_sse_to_viewer
May 8, 2026
Merged

HTM-2016: Create a separate SseEventBus bean for the viewer so viewers don't get administrative broadcasts#1728
mprins merged 1 commit into
HTM-1960_Custom_extract_functionality_for_layer_attributesfrom
HTM-2016_prevent_leaking_admin_sse_to_viewer

Conversation

@mprins
Copy link
Copy Markdown
Contributor

@mprins mprins commented May 5, 2026

HTM-2016 Powered by Pull Request Badge

  • check if it works and add a test (we can check and compare keep-alive messages, as these are different between admin and viewer)
  • Add a note to the readme / documentation

Note this will merge to the feature branch: #1672

@mprins mprins self-assigned this May 5, 2026
@mprins mprins added the bug Something isn't working label May 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 6119432.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@mprins mprins force-pushed the HTM-1960_Custom_extract_functionality_for_layer_attributes branch from 3ef963f to 8ded6a3 Compare May 5, 2026 15:31
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

❌ Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...g/tailormap/api/configuration/TailormapConfig.java 28% 2 Missing and 6 partials ⚠️

Impacted file tree graph

@@                                     Coverage Diff                                      @@
##             HTM-1960_Custom_extract_functionality_for_layer_attributes   #1728   +/-   ##
============================================================================================
- Coverage                                                            77%     77%   -0%     
  Complexity                                                          146     146           
============================================================================================
  Files                                                               162     162           
  Lines                                                              8125    8143   +18     
  Branches                                                            748     754    +6     
============================================================================================
- Hits                                                               6200    6190   -10     
- Misses                                                             1495    1517   +22     
- Partials                                                            430     436    +6     
Files with missing lines Coverage Δ Complexity Δ
...map/api/controller/ServerSentEventsController.java 100% <100%> (ø) 0 <0> (ø)
...troller/admin/ServerSentEventsAdminController.java 100% <100%> (+19%) 0 <0> (ø)
...ilormap/api/service/CreateLayerExtractService.java 62% <100%> (ø) 0 <0> (ø)
...g/tailormap/api/configuration/TailormapConfig.java 56% <28%> (-44%) 0 <0> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Test Results

485 tests  +1   484 ✅ +1   10m 19s ⏱️ + 2m 57s
 58 suites ±0     1 💤 ±0 
 58 files   ±0     0 ❌ ±0 

Results for commit 6119432. ± Comparison against base commit 8ded6a3.

♻️ This comment has been updated with latest results.

@mprins mprins changed the title [WIP] HTM-2016: Create a separate SseEventBus bean for the viewer so viewers don't get administrative braodcasts [WIP] HTM-2016: Create a separate SseEventBus bean for the viewer so viewers don't get administrative broadcasts May 5, 2026
@mprins mprins force-pushed the HTM-2016_prevent_leaking_admin_sse_to_viewer branch from badc8db to e88adab Compare May 7, 2026 12:22
@mprins mprins marked this pull request as ready for review May 7, 2026 12:23
Copilot AI review requested due to automatic review settings May 7, 2026 12:23
@mprins mprins changed the title [WIP] HTM-2016: Create a separate SseEventBus bean for the viewer so viewers don't get administrative broadcasts HTM-2016: Create a separate SseEventBus bean for the viewer so viewers don't get administrative broadcasts May 7, 2026

This comment was marked as outdated.

@mprins mprins force-pushed the HTM-2016_prevent_leaking_admin_sse_to_viewer branch from 7e251a7 to 01f4b04 Compare May 7, 2026 13:35
@mprins mprins requested a review from Copilot May 7, 2026 13:40
@mprins mprins force-pushed the HTM-2016_prevent_leaking_admin_sse_to_viewer branch from 01f4b04 to 6119432 Compare May 7, 2026 13:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Comment thread src/test/java/org/tailormap/api/controller/SseParsingUtils.java
Comment thread README.md
@mprins mprins requested review from a team, matthijsln and steinkobben May 7, 2026 14:01
@mprins mprins merged commit e4bd1a2 into HTM-1960_Custom_extract_functionality_for_layer_attributes May 8, 2026
18 of 19 checks passed
@mprins mprins deleted the HTM-2016_prevent_leaking_admin_sse_to_viewer branch May 8, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants