Skip to content

HTM-1995: prefix table in delete statement with schema when needed#1736

Merged
mprins merged 1 commit into
mainfrom
HTM-1995
May 12, 2026
Merged

HTM-1995: prefix table in delete statement with schema when needed#1736
mprins merged 1 commit into
mainfrom
HTM-1995

Conversation

@mprins
Copy link
Copy Markdown
Contributor

@mprins mprins commented May 12, 2026

HTM-1995 Powered by Pull Request Badge

@mprins mprins self-assigned this May 12, 2026
Copilot AI review requested due to automatic review settings May 12, 2026 12:31
@mprins mprins added the bug Something isn't working label May 12, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates attachment deletion SQL generation to include the database schema prefix when the datastore is configured with a non-empty schema, aligning it with the existing insert/query behavior in AttachmentsHelper.

Changes:

  • Build the DELETE FROM ... statement after creating the JDBCDataStore, so the schema can be determined.
  • Prefix {featureType}_attachments with {schema}. when ds.getDatabaseSchema() is non-empty.

@mprins mprins requested review from a team and matthijsln May 12, 2026 12:36
@mprins mprins enabled auto-merge (rebase) May 12, 2026 12:51
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...api/geotools/featuresources/AttachmentsHelper.java 50% 0 Missing and 1 partial ⚠️

Impacted file tree graph

@@           Coverage Diff            @@
##             main   #1736     +/-   ##
========================================
+ Coverage       5%     76%    +71%     
  Complexity    146     146             
========================================
  Files         162     162             
  Lines        8212    8212             
  Branches      759     760      +1     
========================================
+ Hits          396    6225   +5829     
+ Misses       7783    1545   -6238     
- Partials       33     442    +409     
Files with missing lines Coverage Δ Complexity Δ
...api/geotools/featuresources/AttachmentsHelper.java 80% <50%> (+77%) 4 <0> (ø)

... and 140 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

Test Results

486 tests   483 ✅  9m 17s ⏱️
 58 suites    2 💤
 58 files      1 ❌

For more details on these failures, see this check.

Results for commit 7ea63f4.

@mprins mprins merged commit 893536e into main May 12, 2026
28 of 30 checks passed
@mprins mprins deleted the HTM-1995 branch May 12, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants