Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates attachment deletion SQL generation to include the database schema prefix when the datastore is configured with a non-empty schema, aligning it with the existing insert/query behavior in AttachmentsHelper.
Changes:
- Build the
DELETE FROM ...statement after creating theJDBCDataStore, so the schema can be determined. - Prefix
{featureType}_attachmentswith{schema}.whends.getDatabaseSchema()is non-empty.
matthijsln
approved these changes
May 12, 2026
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1736 +/- ##
========================================
+ Coverage 5% 76% +71%
Complexity 146 146
========================================
Files 162 162
Lines 8212 8212
Branches 759 760 +1
========================================
+ Hits 396 6225 +5829
+ Misses 7783 1545 -6238
- Partials 33 442 +409
... and 140 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Test Results486 tests 483 ✅ 9m 17s ⏱️ For more details on these failures, see this check. Results for commit 7ea63f4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.