Change Dependabot runner from ubuntu-latest to ubuntu-slim#106
Conversation
mprins
added
the
infrastructure
There was a problem hiding this comment.
Pull request overview
This PR attempts to change the GitHub Actions runner from ubuntu-latest to ubuntu-slim across three workflow files. However, ubuntu-slim is not a valid GitHub-hosted runner label.
Changes:
- Modified the
runs-onvalue fromubuntu-latesttoubuntu-slimin the Dependabot auto-merge workflow - Modified the
runs-onvalue fromubuntu-latesttoubuntu-slimin the Renovate config validator workflow - Modified the
runs-onvalue fromubuntu-latesttoubuntu-slimin three jobs within the cleanup/maintenance workflow
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| .github/workflows/dependabot.yml | Changes runner to ubuntu-slim for Dependabot auto-merge job |
| .github/workflows/renovate-configvalidator.yml | Changes runner to ubuntu-slim for Renovate validator job |
| .github/workflows/cleanup.yml | Changes runner to ubuntu-slim for three jobs: stale PR cleanup, workflow cleanup, and Docker image cleanup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| jobs: | ||
| stale: | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-slim |
There was a problem hiding this comment.
The PR title indicates "Change Dependabot runner from ubuntu-latest to ubuntu-slim", but this file is a cleanup/maintenance workflow, not a Dependabot-related workflow. The title should be updated to reflect that multiple workflows are being changed, or the scope of changes should be limited to only the Dependabot workflow as suggested by the title.
| jobs: | ||
| dependabot: | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-slim |
There was a problem hiding this comment.
The runner label 'ubuntu-slim' is not a valid GitHub Actions hosted runner. GitHub Actions provides 'ubuntu-latest', 'ubuntu-22.04', and 'ubuntu-20.04', but not 'ubuntu-slim'. This will cause workflow runs to fail with an error indicating that no runner matching this label could be found. Unless 'ubuntu-slim' is a self-hosted runner configured in this repository's settings (which appears unlikely based on the lack of documentation), this should be reverted to 'ubuntu-latest' or changed to another valid hosted runner label.
| runs-on: ubuntu-slim | |
| runs-on: ubuntu-latest |
| jobs: | ||
| renovate-validator: | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-slim |
There was a problem hiding this comment.
The runner label 'ubuntu-slim' is not a valid GitHub Actions hosted runner. GitHub Actions provides 'ubuntu-latest', 'ubuntu-22.04', and 'ubuntu-20.04', but not 'ubuntu-slim'. This will cause workflow runs to fail with an error indicating that no runner matching this label could be found. Unless 'ubuntu-slim' is a self-hosted runner configured in this repository's settings (which appears unlikely based on the lack of documentation), this should be reverted to 'ubuntu-latest' or changed to another valid hosted runner label.
| runs-on: ubuntu-slim | |
| runs-on: ubuntu-latest |
| jobs: | ||
| stale: | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-slim |
There was a problem hiding this comment.
The runner label 'ubuntu-slim' is not a valid GitHub Actions hosted runner. GitHub Actions provides 'ubuntu-latest', 'ubuntu-22.04', and 'ubuntu-20.04', but not 'ubuntu-slim'. This will cause workflow runs to fail with an error indicating that no runner matching this label could be found. Unless 'ubuntu-slim' is a self-hosted runner configured in this repository's settings (which appears unlikely based on the lack of documentation), this should be reverted to 'ubuntu-latest' or changed to another valid hosted runner label.
|
|
||
| workflows: | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-slim |
There was a problem hiding this comment.
The runner label 'ubuntu-slim' is not a valid GitHub Actions hosted runner. GitHub Actions provides 'ubuntu-latest', 'ubuntu-22.04', and 'ubuntu-20.04', but not 'ubuntu-slim'. This will cause workflow runs to fail with an error indicating that no runner matching this label could be found. Unless 'ubuntu-slim' is a self-hosted runner configured in this repository's settings (which appears unlikely based on the lack of documentation), this should be reverted to 'ubuntu-latest' or changed to another valid hosted runner label.
| dockercleanup: | ||
| name: 'Pruning Untagged Images' | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-slim |
There was a problem hiding this comment.
The runner label 'ubuntu-slim' is not a valid GitHub Actions hosted runner. GitHub Actions provides 'ubuntu-latest', 'ubuntu-22.04', and 'ubuntu-20.04', but not 'ubuntu-slim'. This will cause workflow runs to fail with an error indicating that no runner matching this label could be found. Unless 'ubuntu-slim' is a self-hosted runner configured in this repository's settings (which appears unlikely based on the lack of documentation), this should be reverted to 'ubuntu-latest' or changed to another valid hosted runner label.
| jobs: | ||
| renovate-validator: | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-slim |
There was a problem hiding this comment.
The PR title indicates "Change Dependabot runner from ubuntu-latest to ubuntu-slim", but this file is the Renovate config validator workflow, not a Dependabot-related workflow. The title should be updated to reflect that multiple workflows are being changed, or the scope of changes should be limited to only the Dependabot workflow as suggested by the title.
No description provided.