chore(QTDI-2893): S6201 changes after rebase

Author: undx

component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/validation/spi/ext/TypeValidation.java

@@ -38,10 +38,10 @@ public class TypeValidation implements ValidationExtension {
     @Override
     public Optional<Function<JsonValue, Stream<ValidationError>>> create(final ValidationContext model) {
         final JsonValue value = model.getSchema().get("type");
-        if (value instanceof JsonString) {
+        if (value instanceof JsonString jsonString) {
             return Optional
                     .of(new Impl(model.toPointer(), model.getValueProvider(),
-                            mapType((JsonString) value).toArray(JsonValue.ValueType[]::new)));
+                            mapType(jsonString).toArray(JsonValue.ValueType[]::new)));
         }
         if (value instanceof JsonArray) {
             return Optional

component-form/component-form-model/src/main/java/org/talend/sdk/component/form/model/jsonschema/PojoJsonSchemaBuilder.java

@@ -64,7 +64,7 @@ public JsonSchema.Builder create(final Class<?> pojo) {
     private JsonSchema buildSchema(final Field field) {
         final Type genericType = field.getGenericType();
 
-        if ((genericType instanceof Class && CharSequence.class.isAssignableFrom((Class) genericType))
+        if ((genericType instanceof Class clazz && CharSequence.class.isAssignableFrom(clazz))
                 || genericType == char.class || genericType == Character.class) {
             return schemas.computeIfAbsent((Class) genericType, k -> jsonSchema().withType("string").build());
         } else if (genericType == long.class || genericType == Long.class || genericType == int.class
@@ -76,15 +76,14 @@ private JsonSchema buildSchema(final Field field) {
         } else if (genericType == boolean.class || genericType == Boolean.class) {
             return schemas
                     .computeIfAbsent((Class) genericType, k -> jsonSchema().withType("boolean").build());
-        } else if (genericType instanceof Class) {
-            final Class<?> clazz = (Class) genericType;
+        } else if (genericType instanceof Class classVal) {
+            final Class<?> clazz = classVal;
             return ofNullable(schemas.get(clazz)).orElseGet(() -> {
                 final JsonSchema jsonSchema = create(clazz).build();
                 schemas.put(clazz, jsonSchema);
                 return jsonSchema;
             });
-        } else if (genericType instanceof ParameterizedType) {
-            final ParameterizedType pt = (ParameterizedType) genericType;
+        } else if (genericType instanceof ParameterizedType pt) {
             final Type rawType = pt.getRawType();
             if (!(rawType instanceof Class)) {
                 throw new IllegalArgumentException("Unsupported raw type: " + pt + ", this must be a Class");

component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/BaseProcessorFn.java

@@ -65,8 +65,8 @@ abstract class BaseProcessorFn<O> extends DoFn<Record, O> {
 
     BaseProcessorFn(final Processor processor) {
         this.processor = processor;
-        if (processor instanceof ProcessorImpl) {
-            ((ProcessorImpl) processor)
+        if (processor instanceof ProcessorImpl processorImpl) {
+            processorImpl
                     .getInternalConfiguration()
                     .entrySet()
                     .stream()

component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/TalendIO.java

@@ -77,8 +77,8 @@ public static Base<PBegin, PCollection<Record>, Mapper> read(final Mapper mapper
             String maxRecords = null;
             String maxDurationMs = null;
             boolean hasInternalConfParams = false;
-            if (mapper instanceof PartitionMapperImpl) {
-                Map<String, String> conf = ((PartitionMapperImpl) mapper).getInternalConfiguration();
+            if (mapper instanceof PartitionMapperImpl partitionMapperImpl) {
+                Map<String, String> conf = partitionMapperImpl.getInternalConfiguration();
                 hasInternalConfParams = conf.keySet()
                         .stream()
                         .filter(k -> k.equals("$maxRecords") || k.equals("$maxDurationMs"))
@@ -164,8 +164,8 @@ private static class InfiniteRead extends Base<PBegin, PCollection<Record>, Mapp
         private InfiniteRead(final Mapper delegate, final long maxRecordCount, final long maxDuration) {
             super(delegate);
             // ensure we consider localConfiguration
-            final Map<String, String> internalConf = delegate instanceof PartitionMapperImpl
-                    ? ((PartitionMapperImpl) delegate).getInternalConfiguration()
+            final Map<String, String> internalConf = delegate instanceof PartitionMapperImpl partitionMapper
+                    ? partitionMapper.getInternalConfiguration()
                     : emptyMap();
             StopConfiguration fromLocalConf =
                     (StopConfiguration) Streaming.loadStopStrategy(delegate.plugin(), internalConf);

component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/coder/JsonpJsonObjectCoder.java

@@ -71,7 +71,7 @@ public JsonObject decode(final InputStream inputStream) throws IOException {
 
     @Override
     public boolean equals(final Object obj) {
-        return obj instanceof JsonpJsonObjectCoder && ((JsonpJsonObjectCoder) obj).isValid();
+        return obj instanceof JsonpJsonObjectCoder coder && coder.isValid();
     }
 
     @Override

component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/factory/service/AutoValueFluentApiFactory.java

@@ -164,14 +164,13 @@ private Object createPrimitiveValue(final Object v, final Type type) {
         if (String.class == type) { // fast path
             return v;
         }
-        if (type instanceof Class && ((Class) type).isInstance(v)) {
+        if (type instanceof Class clazz && (clazz.isInstance(v))) {
             return v;
         }
-        if (type instanceof ParameterizedType) {
-            final ParameterizedType pt = (ParameterizedType) type;
+        if (type instanceof ParameterizedType pt) {
             final Type raw = pt.getRawType();
             // we know what we do if we use that
-            if (raw instanceof Class && ((Class) raw).isInstance(v)) {
+            if (raw instanceof Class clazz && clazz.isInstance(v)) {
                 return v;
             }
         }

component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/spi/BeamComponentExtension.java

@@ -66,10 +66,10 @@ public boolean isActive() {
     @Override
     public <T> T unwrap(final Class<T> type, final Object... args) {
         if ("org.talend.sdk.component.design.extension.flows.FlowsFactory".equals(type.getName()) && args != null
-                && args.length == 1 && args[0] instanceof ComponentFamilyMeta.BaseMeta) {
+                && args.length == 1 && args[0] instanceof ComponentFamilyMeta.BaseMeta baseMeta) {
             if (args[0] instanceof ComponentFamilyMeta.ProcessorMeta) {
                 try {
-                    final FlowsFactory factory = FlowsFactory.get((ComponentFamilyMeta.BaseMeta) args[0]);
+                    final FlowsFactory factory = FlowsFactory.get(baseMeta);
                     factory.getOutputFlows();
                     return type.cast(factory);
                 } catch (final Exception e) { // no @ElementListener, let's default for native transforms

component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/spi/BeamProducerFinder.java

@@ -65,10 +65,10 @@ public Iterator<Record> find(final String familyName, final String inputName, fi
         } catch (Exception e) {
             log.warn("Component Kit Mapper instantiation failed, trying to wrap native beam mapper...");
             final Object delegate = ((Delegated) mapper).getDelegate();
-            if (delegate instanceof PTransform) {
+            if (delegate instanceof PTransform pTransform) {
                 final UUID uuid = UUID.randomUUID();
                 QUEUE.put(uuid, new ArrayBlockingQueue<>(QUEUE_SIZE, true));
-                return new QueueInput(delegate, familyName, inputName, familyName, (PTransform) delegate,
+                return new QueueInput(delegate, familyName, inputName, familyName, pTransform,
                         uuid);
             }
             throw new IllegalStateException(e);

component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/factory/service/io/AutoValue_CustomJdbcIO_DataSourceConfiguration.java

@@ -86,8 +86,7 @@ public boolean equals(final Object o) {
         if (o == this) {
             return true;
         }
-        if (o instanceof CustomJdbcIO.DataSourceConfiguration) {
-            CustomJdbcIO.DataSourceConfiguration that = (CustomJdbcIO.DataSourceConfiguration) o;
+        if (o instanceof CustomJdbcIO.DataSourceConfiguration that) {
             return ((this.driverClassName == null) ? (that.getDriverClassName() == null)
                     : this.driverClassName.equals(that.getDriverClassName()))
                     && ((this.url == null) ? (that.getUrl() == null) : this.url.equals(that.getUrl()))

component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/transformer/BeamIOTransformerTest.java

@@ -148,8 +148,8 @@ void coderSerialization() {
     private Object newInstance(final Class<?> aClass, final ClassLoader validationLoader) {
         try {
             final Object instance = aClass.getConstructor().newInstance();
-            if (instance instanceof SetValidator) {
-                ((SetValidator) instance)
+            if (instance instanceof SetValidator setValidatorVal) {
+                setValidatorVal
                         .setValidator(
                                 () -> assertEquals(Thread.currentThread().getContextClassLoader(), validationLoader));
             }