feat(QTDI-1291): cover old functionality

Author: ozhelezniak-talend

component-server-parent/component-server/src/test/java/org/talend/sdk/component/server/front/ActionResourceImplTest.java

@@ -1,12 +1,12 @@
 /**
  * Copyright (C) 2006-2026 Talend Inc. - www.talend.com
- *
+ * <p>
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- *
+ * <p>
  * http://www.apache.org/licenses/LICENSE-2.0
- *
+ * <p>
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -19,6 +19,7 @@
 import static javax.ws.rs.core.MediaType.APPLICATION_JSON_TYPE;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.talend.sdk.component.api.record.Schema.Type.LONG;
 import static org.talend.sdk.component.api.record.Schema.Type.RECORD;
@@ -39,6 +40,7 @@
 import javax.ws.rs.client.WebTarget;
 import javax.ws.rs.core.GenericType;
 import javax.ws.rs.core.Response;
+import javax.ws.rs.core.Response.Status;
 
 import org.apache.meecrowave.junit5.MonoMeecrowaveConfig;
 import org.junit.jupiter.api.Disabled;
@@ -182,7 +184,7 @@ void testDiscoverSchemaException(final HandleErrorWith origin) {
                 .queryParam("action", "discoverSchemaException" + origin)
                 .request(APPLICATION_JSON_TYPE)
                 .post(Entity.entity(new HashMap<String, String>(), APPLICATION_JSON_TYPE));
-        assertEquals(400, error.getStatus());
+        assertEquals(Status.BAD_REQUEST.getStatusCode(), error.getStatus());
         final ErrorPayload errorPayload = error.readEntity(ErrorPayload.class);
         assertEquals(ErrorDictionary.ACTION_ERROR, errorPayload.getCode());
         assertEquals(origin.toString(), errorPayload.getSubCode());
@@ -197,6 +199,68 @@ static Stream<Arguments> handleErrorWithSource() {
                 Arguments.of(HandleErrorWith.EXECUTE_LIFECYCLE));
     }
 
+    @Test
+    void emptyAction() {
+        final Response error = base
+                .path("action/execute")
+                .queryParam("type", "user")
+                .queryParam("family", "custom")
+                .request(APPLICATION_JSON_TYPE)
+                .post(Entity.entity(new HashMap<String, String>(), APPLICATION_JSON_TYPE));
+        assertEquals(Status.BAD_REQUEST.getStatusCode(), error.getStatus());
+        final ErrorPayload errorPayload = error.readEntity(ErrorPayload.class);
+        assertEquals(ErrorDictionary.ACTION_MISSING, errorPayload.getCode());
+        assertNull(errorPayload.getSubCode());
+        assertEquals("Action can't be null", errorPayload.getDescription());
+    }
+
+    @Test
+    void emptyType() {
+        final Response error = base
+                .path("action/execute")
+                .queryParam("family", "custom")
+                .queryParam("action", "backendException")
+                .request(APPLICATION_JSON_TYPE)
+                .post(Entity.entity(new HashMap<String, String>(), APPLICATION_JSON_TYPE));
+        assertEquals(Status.BAD_REQUEST.getStatusCode(), error.getStatus());
+        final ErrorPayload errorPayload = error.readEntity(ErrorPayload.class);
+        assertEquals(ErrorDictionary.TYPE_MISSING, errorPayload.getCode());
+        assertNull(errorPayload.getSubCode());
+        assertEquals("Type can't be null", errorPayload.getDescription());
+    }
+
+    @Test
+    void emptyFamily() {
+        final Response error = base
+                .path("action/execute")
+                .queryParam("type", "user")
+                .queryParam("action", "backendException")
+                .request(APPLICATION_JSON_TYPE)
+                .post(Entity.entity(new HashMap<String, String>(), APPLICATION_JSON_TYPE));
+        assertEquals(Status.BAD_REQUEST.getStatusCode(), error.getStatus());
+        final ErrorPayload errorPayload = error.readEntity(ErrorPayload.class);
+        assertEquals(ErrorDictionary.FAMILY_MISSING, errorPayload.getCode());
+        assertNull(errorPayload.getSubCode());
+        assertEquals("Family can't be null", errorPayload.getDescription());
+    }
+
+
+    @Test
+    void emptyActionMeta() {
+        final String actionName = "notExistedAction";
+        final Response error = base
+                .path("action/execute")
+                .queryParam("type", "user")
+                .queryParam("family", "custom")
+                .queryParam("action", actionName)
+                .request(APPLICATION_JSON_TYPE)
+                .post(Entity.entity(new HashMap<String, String>(), APPLICATION_JSON_TYPE));
+        assertEquals(Status.NOT_FOUND.getStatusCode(), error.getStatus());
+        final ErrorPayload errorPayload = error.readEntity(ErrorPayload.class);
+        assertEquals(ErrorDictionary.ACTION_MISSING, errorPayload.getCode());
+        assertEquals("No action with id '" + actionName + "'", errorPayload.getDescription());
+    }
+
     @Test
     void executeWithEnumParam() {
         final Response error = base
@@ -228,37 +292,37 @@ void checkSchemaSerialization() {
                 .post(Entity.entity(emptyMap(), APPLICATION_JSON_TYPE), String.class);
         final String expected =
                 """
-                {
-                  "entries":[
-                    {
-                      "elementSchema":{
-                        "entries":[
-                        ],
-                        "metadata":[
-                        ],
-                        "props":{
-
-                        },
-                        "type":"STRING"
-                      },
-                      "errorCapable":false,
-                      "metadata":false,
-                      "name":"array",
-                      "nullable":false,
-                      "props":{
-
-                      },
-                      "type":"ARRAY",
-                      "valid":true
-                    }
-                  ],
-                  "metadata":[
-                  ],
-                  "props":{
-                    "talend.fields.order":"array"
-                  },
-                  "type":"RECORD"
-                }""";
+                        {
+                          "entries":[
+                            {
+                              "elementSchema":{
+                                "entries":[
+                                ],
+                                "metadata":[
+                                ],
+                                "props":{
+                        
+                                },
+                                "type":"STRING"
+                              },
+                              "errorCapable":false,
+                              "metadata":false,
+                              "name":"array",
+                              "nullable":false,
+                              "props":{
+                        
+                              },
+                              "type":"ARRAY",
+                              "valid":true
+                            }
+                          ],
+                          "metadata":[
+                          ],
+                          "props":{
+                            "talend.fields.order":"array"
+                          },
+                          "type":"RECORD"
+                        }""";
         assertEquals(expected, schema);
     }
 
@@ -302,7 +366,7 @@ void checkDiscoverProcessorSchema() {
 
     @Disabled
     @ParameterizedTest
-    @ValueSource(strings = { "en", "fr" })
+    @ValueSource(strings = {"en", "fr"})
     void i18nParameterized(final String lang) {
         final Response error = base
                 .path("action/execute")
@@ -351,7 +415,7 @@ void checkLangIsAvailable() {
     }
 
     private void assertAction(final String component, final String type, final String name, final int params,
-            final ActionItem value) {
+                              final ActionItem value) {
         assertEquals(component, value.getComponent());
         assertEquals(type, value.getType());
         assertEquals(name, value.getName());