Skip to content

Commit 669c984

Browse files
Trecekclaude
andcommitted
fix(review): guard step.with_args before subscripting in test_check_flake_loop_step_exists
If a run_python step has no with: block, step.with_args is None and subscripting it raises TypeError instead of a clear AssertionError. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 2dc9d35 commit 669c984

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

tests/recipe/test_resolve_ci_routing_invariant.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,9 @@ def test_check_flake_loop_step_exists(recipe_name: str) -> None:
275275
assert step.tool == "run_python", (
276276
f"{recipe_name}: check_flake_loop must use run_python, got {step.tool!r}"
277277
)
278+
assert step.with_args is not None, (
279+
f"{recipe_name}: check_flake_loop run_python step has no with_args block"
280+
)
278281
assert step.with_args["callable"] == "autoskillit.smoke_utils.check_loop_iteration", (
279282
f"{recipe_name}: check_flake_loop must use check_loop_iteration callable"
280283
)

0 commit comments

Comments
 (0)