fix(review): move module-level assert to dedicated test (tools_recipe.py)

Replaces the module-level `assert FLEET_DISPATCH_TOOLS <= GATED_TOOLS`
in tools_recipe.py with a proper pytest test in test_canonical_constant_consumption.py.
Module-level asserts are silently disabled under python -O and produce unstructured
AssertionError output; the invariant is now enforced by the test suite.
The FLEET_DISPATCH_TOOLS import is retained with # noqa: F401 as the sole
production consumer required by test_registry_constants_have_production_consumer.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: Trecek

src/autoskillit/server/tools/tools_recipe.py

@@ -13,7 +13,7 @@
     build_config_authoritative_layer,
     resolve_ingredient_defaults,
 )
-from autoskillit.core import FLEET_DISPATCH_TOOLS, get_logger, temp_dir_display_str
+from autoskillit.core import FLEET_DISPATCH_TOOLS, get_logger, temp_dir_display_str  # noqa: F401
 from autoskillit.pipeline import GATED_TOOLS, UNGATED_TOOLS  # noqa: F401
 from autoskillit.server import mcp
 from autoskillit.server._guards import _require_enabled
@@ -30,11 +30,6 @@
 )
 from autoskillit.server.tools._cancellation_shield import _cancellation_shield
 
-assert FLEET_DISPATCH_TOOLS <= GATED_TOOLS, (
-    "FLEET_DISPATCH_TOOLS must be a subset of GATED_TOOLS — "
-    f"extra: {sorted(FLEET_DISPATCH_TOOLS - GATED_TOOLS)}"
-)
-
 logger = get_logger(__name__)
 
 

tests/arch/test_canonical_constant_consumption.py

@@ -159,3 +159,14 @@ def test_exemptions_reference_real_constants() -> None:
         f"Exemption dict contains names not found in constants files: {sorted(stale)}. "
         f"Remove stale entries."
     )
+
+
+def test_fleet_dispatch_tools_subset_of_gated_tools() -> None:
+    """FLEET_DISPATCH_TOOLS must be a subset of GATED_TOOLS."""
+    from autoskillit.core import FLEET_DISPATCH_TOOLS
+    from autoskillit.pipeline import GATED_TOOLS
+
+    extra = FLEET_DISPATCH_TOOLS - GATED_TOOLS
+    assert not extra, (
+        f"FLEET_DISPATCH_TOOLS must be a subset of GATED_TOOLS — extra: {sorted(extra)}"
+    )