Skip to content

Commit e13a818

Browse files
Trecekclaude
andcommitted
fix(review): merge duplicate vacuous-gate test and add explicit dispatch_feasible assertion
Merge test_vacuous_gate_does_not_block_dispatch into test_codex_implementation_dispatch_infeasible (eliminating redundant load_and_validate call) and add explicit `assert dispatch_feasible is False` in the else branch of test_codex_capability_gate_recipes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 9ce4cb6 commit e13a818

1 file changed

Lines changed: 3 additions & 13 deletions

File tree

tests/recipe/test_bundled_recipes_dispatch_ready.py

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -279,19 +279,6 @@ def test_codex_implementation_dispatch_infeasible() -> None:
279279
"When all backend_supports_git_write-gated steps are pruned, "
280280
"gate_backend_write is vacuous and should NOT block dispatch."
281281
)
282-
283-
284-
def test_vacuous_gate_does_not_block_dispatch() -> None:
285-
"""When gate_backend_write's downstream operations are all pruned,
286-
the gate is vacuous and dispatch_feasible must be True."""
287-
result = load_and_validate(
288-
"implementation",
289-
project_dir=_PROJECT_ROOT,
290-
ingredient_overrides={"backend_supports_git_write": "false"},
291-
backend_name="codex",
292-
)
293-
assert result["valid"] is True
294-
assert result.get("dispatch_feasible") is True
295282
assert "gate_backend_write" not in result.get("infeasible_steps", [])
296283

297284

@@ -357,4 +344,7 @@ def test_codex_capability_gate_recipes(recipe_name: str) -> None:
357344
if dispatch_feasible is True:
358345
assert "gate_backend_write" not in infeasible_steps
359346
else:
347+
assert dispatch_feasible is False, (
348+
f"Expected dispatch_feasible to be explicitly False, got {dispatch_feasible!r}"
349+
)
360350
assert "gate_backend_write" in infeasible_steps

0 commit comments

Comments
 (0)