Implementation Plan: Fix Logger Initialization Deviations in Three Modules#3899
Merged
Trecek merged 1 commit intoJun 8, 2026
Merged
Conversation
Replace bare `get_logger()` calls in `_process_pty.py`, `_codex_config.py`, and `sidecar.py` with `get_logger(__name__)` to bind the module name for structured log correlation. In `_process_pty.py`, also remove the direct `import structlog` (the only file in `execution/process/` not using `autoskillit.core.get_logger`) and switch to the `autoskillit.core` wrapper. In `claude.py`, document the rationale for the existing `logging.getLogger` stdlib fallback (TID251): it runs before `configure_logging()`, where a structlog proxy would emit to stderr via the import-time WriteLoggerFactory and corrupt MCP stdio. Resolves cohesion audit finding F-C3-01. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Trecek
commented
Jun 8, 2026
Trecek
left a comment
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: approved
Trecek
commented
Jun 8, 2026
Trecek
left a comment
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit review passed. No blocking issues found.
Trecek
deleted the
fix-logger-initialization-deviations-in-three-modules/3770
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix four confirmed logger initialization deviations from the validated cohesion audit (F-C3-01):
execution/process/_process_pty.py:11— Replacestructlog.get_logger()withget_logger(__name__)fromautoskillit.core, eliminating both the direct structlog import and the missing module-name binding.execution/backends/_codex_config.py:38— Add__name__argument to existingget_logger()call.fleet/sidecar.py:12— Add__name__argument to existingget_logger()call.execution/backends/claude.py:72— Add rationale comment to the existing# noqa: TID251suppression explaining why stdliblogging.getLoggeris used instead of the structlog wrapper.Closes #3770
Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-20260607-223738-023290/.autoskillit/temp/make-plan/fix_logger_initialization_deviations_plan_2026-06-07_224600.md🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary
* Step used a non-Anthropic provider; caching behavior may differ.
Token Efficiency
Model Usage Breakdown