Skip to content

Implementation Plan: Rename cli/session/ Files to Match _session_ Prefix Convention#3903

Merged
Trecek merged 3 commits into
developfrom
rename-cli-session-files-to-match-session-prefix-convention/3771
Jun 8, 2026
Merged

Implementation Plan: Rename cli/session/ Files to Match _session_ Prefix Convention#3903
Trecek merged 3 commits into
developfrom
rename-cli-session-files-to-match-session-prefix-convention/3771

Conversation

@Trecek

@Trecek Trecek commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Rename four files in src/autoskillit/cli/session/ to follow the _session_ prefix convention already established by _session_launch.py and _session_picker.py, and consistent with peer directories cli/doctor/ (_doctor_*) and cli/fleet/ (_fleet_*):

Current Name New Name
_constants.py _session_constants.py
_cook.py _session_cook.py
_order.py _session_order.py
_reload.py _session_reload.py

Update all import paths, monkeypatch/patch string targets, arch test path literals and registries, the test-source-map.json coverage oracle, and cli/session/CLAUDE.md.

Implementation Plan

Plan file: /home/talon/projects/autoskillit-runs/impl-20260607-232505-636268/.autoskillit/temp/make-plan/rename_cli_session_files_plan_2026-06-07_232505.md

Closes #3771

🤖 Generated with Claude Code via AutoSkillit

Token Usage Summary

Step Model count uncached output cache_read peak_ctx turns cache_write time
plan* opus[1m] 1 8.6k 22.2k 1.2M 99.1k 50 82.1k 10m 47s
verify* sonnet 1 92 16.1k 629.6k 76.5k 34 54.9k 7m 55s
implement* MiniMax-M3 1 104.2k 20.8k 3.0M 106.7k 154 0 15m 13s
audit_impl* sonnet 1 1.8k 20.7k 377.2k 62.8k 23 62.8k 7m 0s
prepare_pr* MiniMax-M3 1 43.3k 4.8k 301.9k 49.0k 18 0 2m 19s
compose_pr* MiniMax-M3 1 36.8k 1.9k 189.4k 39.3k 13 0 1m 4s
review_pr* sonnet 3 384 43.1k 2.4M 84.6k 119 180.0k 12m 23s
resolve_review* sonnet 1 165 8.0k 1.0M 64.4k 52 43.3k 5m 15s
Total 195.4k 137.5k 9.1M 106.7k 423.1k 1h 1m

* Step used a non-Anthropic provider; caching behavior may differ.

Token Efficiency

Step LoC Changed cache_read/LoC cache_write/LoC output/LoC
plan 0
verify 0
implement 254 11689.2 0.0 81.8
audit_impl 0
prepare_pr 0
compose_pr 0
review_pr 0
resolve_review 2 521201.5 21654.0 3991.5
Total 256 35475.1 1652.7 537.3

Model Usage Breakdown

Model steps uncached output cache_read cache_write time
opus[1m] 1 8.6k 22.2k 1.2M 82.1k 10m 47s
sonnet 4 2.4k 87.9k 4.5M 341.0k 32m 34s
MiniMax-M3 3 184.3k 27.5k 3.5M 0 18m 37s

Trecek added 2 commits June 7, 2026 23:53
Rename four source modules in src/autoskillit/cli/session/ to match the
_session_ prefix already established by _session_launch.py and
_session_picker.py:

  _constants.py -> _session_constants.py
  _cook.py      -> _session_cook.py
  _order.py     -> _session_order.py
  _reload.py    -> _session_reload.py

Update sibling source-side import paths in cli/__init__.py, cli/app.py,
cli/session/__init__.py, _session_cook.py, and _session_launch.py to
reference the new module names.

Also update cli/session/CLAUDE.md file listing to reflect the new names.
Update all test-file references to the four renamed cli/session/ modules
(_constants, _cook, _order, _reload → _session_ prefixed), including:

- 15 test files with import statements, monkeypatch.setattr() patch
  strings, and patch() string targets
- Arch test path literals, ALLOWED tuples, _PRINT_EXEMPT frozenset
  entries, and helper function bodies in tests/arch/
- Docstrings, error messages, assert messages, and .exists() path
  assertions referencing the old filenames
- tests/arch/CLAUDE.md test catalog description
- tests/contracts/test_claude_code_interface_contracts.py comment
- tests/core/test_type_constants.py comment
- .autoskillit/test-source-map.json: 4 keys renamed with test arrays
  preserved

Also shorten test_ast_rules.py docstring to satisfy line-length=99
after the _session_ prefix widened the path.

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: approved_with_comments

Comment thread tests/arch/test_ast_rules.py Outdated
…t_rules.py

The abbreviation 'user-facing print() OK' was overly terse; use 'user-facing terminal
output OK' which is clearer and stays within the 99-char line-length limit.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Trecek Trecek added this pull request to the merge queue Jun 8, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 8, 2026
@Trecek Trecek added this pull request to the merge queue Jun 8, 2026
Merged via the queue into develop with commit b6262a4 Jun 8, 2026
3 checks passed
@Trecek Trecek deleted the rename-cli-session-files-to-match-session-prefix-convention/3771 branch June 8, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant