Implementation Plan: Add TestCodexCanaryEventTypes Canary Test#3943
Merged
Trecek merged 1 commit intoJun 8, 2026
Merged
Conversation
Add TestCodexCanaryEventTypes parametrized over all 7 fixture files. For each event, call CodexEventType.from_ndjson(raw_type) and assert the result is not CodexEventType.UNKNOWN. This breaks immediately if a new event type is committed to a fixture without first adding the corresponding enum member. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Trecek
commented
Jun 8, 2026
Trecek
left a comment
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: approved
Trecek
deleted the
t4-p1-a4-wp1-assert-that-every-ndjson-event-type-in-all-7-co/3918
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
TestCodexCanaryEventTypestest class totests/execution/backends/test_codex_fixtures.pywith a single parametrized method that asserts every NDJSON event in all 7 Codex fixture files resolves to a knownCodexEventTypemember (notUNKNOWN). This provides a canary that breaks immediately if a new event type appears in committed fixtures without a corresponding enum entry.Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-20260608-125758-187777/.autoskillit/temp/make-plan/codex_canary_event_types_plan_2026-06-08_130500.mdCloses #3918
🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary
* Step used a non-Anthropic provider; caching behavior may differ.
Token Efficiency
Model Usage Breakdown