T5-P1-A2-WP1 — Ensure open_kitchen Failure Predicate Keys on JSON Field#4066
Merged
Trecek merged 1 commit intoJun 11, 2026
Merged
Conversation
…ailure predicates The substring '--- INGREDIENTS TABLE ---' is injected by a hook formatter on Claude Code and is absent on Codex, causing silent failure-detection blindness on the Codex backend. The JSON field 'ingredients_table' is present in all open_kitchen responses regardless of backend. Updated both the orchestrator prompt (cli/_prompts_orchestrator.py) and the food truck prompt (fleet/_prompts.py) failure predicates to use the JSON field check. Tests in test_orchestrator_prompt_contract.py renamed and inverted to assert the new behavior; new test added to test_food_truck_prompt.py for the food truck prompt. Refs: T5-P1-A2-WP1 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Trecek
commented
Jun 11, 2026
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: approved
Trecek
commented
Jun 11, 2026
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit review passed. No blocking issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the
--- INGREDIENTS TABLE ---substring check in the open_kitchen failure predicate with an"ingredients_table": nullJSON field check. This change affects two prompt builders (_build_orchestrator_promptincli/_prompts_orchestrator.pyand_build_food_truck_promptinfleet/_prompts.py) and their corresponding test files. The substring marker is injected by a hook and is absent on Codex, causing silent failure-detection blindness on that backend. The JSON field is present in allopen_kitchenresponses regardless of backend.Closes #3999
Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-20260611-073832-079933/.autoskillit/temp/make-plan/T5-P1-A2-WP1-ensure-open-kitchen-predicate-json-field_plan_2026-06-11_074300.md🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary
* Step used a non-Anthropic provider; caching behavior may differ.
Token Efficiency
Model Usage Breakdown