Implementation Plan: T5-P2-A6-WP2 Ensure Every Frozenset/Registry Constant Has a Production Consumer#4079
Merged
Trecek merged 3 commits intoJun 12, 2026
Conversation
Trecek
commented
Jun 12, 2026
Trecek
left a comment
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: approved_with_comments
Trecek
commented
Jun 12, 2026
Trecek
left a comment
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit review: warning-only findings detected. See inline comments — no blocking changes required.
Add a generalized arch test that scans every module-level constant matching *_REGISTRY, *_TOOLS, *_TAGS, or *_NAMES in _type_constants_registries.py and _type_constants.py, asserting each is either imported by production src/ code or documented in _REGISTRY_EXEMPTIONS with a rationale. Two real consumers were missing and are now wired up: - FLEET_DISPATCH_TOOLS is imported in server/tools/tools_recipe.py with a load-bearing structural assertion that it is a subset of GATED_TOOLS. - RETIRED_AGENT_NAMES is imported in server/tools/tools_agents.py and used to short-circuit unlock_agent_pack with a 'has been retired' error before touching enable_components. FREE_RANGE_TOOLS and FLEET_TOOLS are exempt (alias-derived and test-consumed respectively) with documented rationales. Tests: adds test_registry_constants_have_production_consumer, test_exemption_rationales_are_nonempty, test_exemptions_reference_real_constants, and test_unlock_agent_pack_rejects_retired_names.
….py) Replaces the module-level `assert FLEET_DISPATCH_TOOLS <= GATED_TOOLS` in tools_recipe.py with a proper pytest test in test_canonical_constant_consumption.py. Module-level asserts are silently disabled under python -O and produce unstructured AssertionError output; the invariant is now enforced by the test suite. The FLEET_DISPATCH_TOOLS import is retained with # noqa: F401 as the sole production consumer required by test_registry_constants_have_production_consumer. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ssertion Makes the "No registry constants found" assertion diagnostic message include the actual constants_files list so failures caused by pkg_root() misresolution or file renames include actionable path information. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Trecek
force-pushed
the
t5-p2-a6-wp2-ensure-every-frozenset-registry-constant-matchi/4007
branch
from
c94c5d5 to
efcf283
Compare
Trecek
deleted the
t5-p2-a6-wp2-ensure-every-frozenset-registry-constant-matchi/4007
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the dead-canonical-constant arch defense to cover
*_REGISTRY,*_TOOLS,*_TAGS, and*_NAMESconstants in both_type_constants_registries.pyand_type_constants.py. Three changes: (1) importFLEET_DISPATCH_TOOLSintools_recipe.pywith a structural assertion, (2) importRETIRED_AGENT_NAMESintools_agents.pywith a retired-pack guard inunlock_agent_pack, (3) add a generalized test intest_canonical_constant_consumption.pywith an exemption dict for alias-backed and test-only constants.Closes #4007
Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-20260611-170755-631133/.autoskillit/temp/make-plan/t5_p2_a6_wp2_registry_constant_consumption_plan_2026-06-11_174000.md🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary
* Step used a non-Anthropic provider; caching behavior may differ.
Token Efficiency
Model Usage Breakdown