Skip to content

Implementation Plan: T5-P4-A2-WP2 Make build_inspector_cmd a Proper Capability-Gated Method#4093

Merged
Trecek merged 3 commits into
developfrom
t5-p4-a2-wp2-make-build-inspector-cmd-a-proper-capability-ga/4017
Jun 12, 2026
Merged

Implementation Plan: T5-P4-A2-WP2 Make build_inspector_cmd a Proper Capability-Gated Method#4093
Trecek merged 3 commits into
developfrom
t5-p4-a2-wp2-make-build-inspector-cmd-a-proper-capability-ga/4017

Conversation

@Trecek

@Trecek Trecek commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

Replace the unchecked RuntimeError stubs in both ClaudeCodeBackend.build_inspector_cmd and CodexBackend.build_inspector_cmd with a proper CapabilityNotSupportedError that is raised only when inspector_capable=False. This involves:

  1. Defining CapabilityNotSupportedError(Exception) in core/types/_type_exceptions.py with structured capability and backend_name fields
  2. Replacing RuntimeError raises in both backends with CapabilityNotSupportedError
  3. Removing inspector_capable from _FORWARD_DECLARED (it now has a production consumer)
  4. Updating conformance tests to assert the new exception type
  5. Adding a parametrized arch test in test_backend_behavioral_contract.py

Implementation Plan

Plan file: /home/talon/projects/autoskillit-runs/impl-20260612-102320-415368/.autoskillit/temp/make-plan/t5-p4-a2-wp2-capability-gated-build-inspector-cmd_plan_2026-06-12_103500.md

Closes #4017

🤖 Generated with Claude Code via AutoSkillit

Token Usage Summary

Step Model count uncached output cache_read peak_ctx turns cache_write time
plan* opus[1m] 1 3.5k 11.9k 1.1M 94.3k 40 73.3k 10m 33s
verify* sonnet 1 172 13.7k 1.1M 65.3k 72 44.4k 4m 17s
implement* MiniMax-M3 1 2.0M 8.4k 0 0 74 0 4m 16s
fix* sonnet 1 126 5.2k 692.4k 59.5k 42 38.6k 5m 34s
audit_impl* sonnet 1 46 16.1k 168.1k 43.3k 17 38.9k 5m 34s
prepare_pr* MiniMax-M3 1 196.1k 2.3k 0 0 13 0 55s
compose_pr* MiniMax-M3 1 176.6k 1.2k 0 0 11 0 46s
review_pr* sonnet 1 156 29.7k 1.0M 78.0k 48 57.9k 6m 46s
resolve_review* sonnet 1 205 15.7k 1.5M 81.2k 60 61.0k 7m 53s
diagnose_ci* MiniMax-M3 1 277.2k 2.0k 0 0 16 0 1m 6s
resolve_ci* sonnet 1 158 6.4k 908.4k 56.9k 49 36.3k 4m 1s
Total 2.7M 112.8k 6.5M 94.3k 350.4k 51m 44s

* Step used a non-Anthropic provider; caching behavior may differ.

Token Efficiency

Step LoC Changed cache_read/LoC cache_write/LoC output/LoC
plan 0
verify 0
implement 50 0.0 0.0 167.2
fix 7 98910.0 5514.4 745.6
audit_impl 0
prepare_pr 0
compose_pr 0
review_pr 0
resolve_review 0
diagnose_ci 0
resolve_ci 7 129768.6 5190.9 914.9
Total 64 102109.6 5475.1 1762.0

Model Usage Breakdown

Model steps uncached output cache_read cache_write time
opus[1m] 1 3.5k 11.9k 1.1M 73.3k 10m 33s
sonnet 6 863 86.9k 5.4M 277.1k 34m 7s
MiniMax-M3 4 2.7M 14.0k 0 0 7m 2s

Trecek added 3 commits June 12, 2026 10:42
…portedError

Replace unchecked RuntimeError stubs in ClaudeCodeBackend and CodexBackend
build_inspector_cmd with proper CapabilityNotSupportedError raised only when
inspector_capable=False. This graduates inspector_capable from
_FORWARD_DECLARED (it now has a production consumer) and makes the
CapabilityNotSupportedError exception available via autoskillit.core for
downstream consumers.

Changes:
- Add CapabilityNotSupportedError in core/types/_type_exceptions.py
  (subclasses Exception, exposes capability + backend_name fields)
- Add re-export to core/__init__.pyi stub
- Replace RuntimeError in both backends with proper capability-gated guard
  plus AssertionError dead-code tail (test_no_not_implemented forbids
  NotImplementedError on registered backend classes)
- Remove inspector_capable from _FORWARD_DECLARED in test_capability_consumption
- Update test_build_inspector_cmd_raises_when_not_capable to assert
  CapabilityNotSupportedError with structured field validation
- Add parametrized test_incapable_backends_raise_capability_not_supported
  in test_backend_behavioral_contract
- Add inspector_capable entry to CAPABILITY_METHOD_MAP
… limit

_type_exceptions is now imported by execution/backends after CapabilityNotSupportedError
was added; MODULE_CASCADE_CORE must include 'execution' to pass the cascade guard.

codex.py grew to 1061 lines due to build_inspector_cmd capability gate; bump
_LINE_LIMIT_EXEMPTIONS ceiling from 1060 to 1062 with rationale.
…tion

commit 35654aa added 'execution' to MODULE_CASCADE_CORE["_type_exceptions"]
in _test_filter.py after CapabilityNotSupportedError was added to
_type_exceptions.py and imported by execution/backends, but
test_type_exceptions_cascade and test_type_exceptions_narrow_cascade
were not updated to match the new 5-member cascade set.
@Trecek Trecek added this pull request to the merge queue Jun 12, 2026
Merged via the queue into develop with commit b82ed64 Jun 12, 2026
3 checks passed
@Trecek Trecek deleted the t5-p4-a2-wp2-make-build-inspector-cmd-a-proper-capability-ga/4017 branch June 12, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant