Implementation Plan: T5-P5-A12-WP1 Make diagram staleness enforcement automated#4103
Merged
Trecek merged 4 commits intoJun 13, 2026
Conversation
Parametrized arch test that runs check_diagram_staleness against every bundled recipe YAML. Recipes with pre-rendered diagrams must not be stale (PASS); recipes without diagrams are marked xfail(strict=True) so CI blocks if a diagram is added without removing the xfail marker (XPASS becomes a FAILURE under strict mode). Meta-tests enforce minimum recipe count (>= 10) and xfail cap shrink enforcement (<= 10) so the missing-diagram set can only shrink over time. Updates tests/arch/AGENTS.md file table to keep the sub-AGENTS.md completeness pre-commit hook passing. Refs T5-P5-A12-WP1
The diagram freshness test (added in the previous commit) caught four diagrams with outdated or placeholder hashes: implementation-groups, merge-prs, and remediation had zero-hash placeholders; implementation had a hash that predated a subsequent YAML edit. Update each header comment to match the current compute_recipe_hash() value so check_diagram_staleness() reports not-stale.
…ts missing diagrams as stale xfail(strict=True) on recipes without diagrams relies on check_diagram_staleness returning True for missing files. Add an explicit test to protect this contract against regression if the function's behavior for absent diagrams is ever changed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…WITHOUT_DIAGRAMS from set difference Eliminates the inline set(_RECIPES_WITH_DIAGRAMS) construction inside the complement comprehension and the separate _RECIPES_WITHOUT_DIAGRAMS intermediate. _WITHOUT_SET is now computed directly as a set difference, and _RECIPES_WITHOUT_DIAGRAMS derives from it via sorted(), making the derivation chain explicit and reducing redundant intermediate state. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Trecek
commented
Jun 13, 2026
Trecek
left a comment
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit review passed. No blocking issues found.
Trecek
deleted the
t5-p5-a12-wp1-make-diagram-staleness-enforcement-automated-a/4031
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create
tests/arch/test_recipe_diagram_freshness.py— a parametrized arch test that runscheck_diagram_stalenessagainst every bundled recipe YAML. Recipes with pre-rendered diagrams must not be stale (PASS); recipes without diagrams are markedxfail(strict=True)so CI blocks if a diagram is added without removing the xfail marker (XPASS → FAIL). Three meta-tests enforce minimum recipe count (>= 10), xfail cap shrink enforcement (<= 10), and collection sanity. Updatetests/arch/AGENTS.mdfile table for the pre-commit hook invariant.Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-20260612-235015-900129/.autoskillit/temp/make-plan/t5-p5-a12-wp1-diagram-freshness_plan_2026-06-12_235500.mdCloses #4031
🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary
* Step used a non-Anthropic provider; caching behavior may differ.
Token Efficiency
Model Usage Breakdown