Implementation Plan: Discipline Delivery Channel Matrix Contract#4119
Merged
Trecek merged 3 commits intoJun 27, 2026
Merged
Conversation
Adds tests/contracts/test_discipline_delivery_matrix.py encoding the session-type x backend discipline-delivery matrix as a parametrized 8-case contract suite. Each combination asserts the PRIMARY delivery channel is populated via the correct builder (--append-system-prompt for Claude, developer_instructions= for Codex) and that SESSION_TYPE is correctly threaded through env for headless variants. Sous-chef composition is verified to flow into orchestrator and open-kitchen prompts but NOT fleet dispatch. Updates tests/contracts/AGENTS.md file registry.
…t test Removes the hardcoded _SESSION_TYPE_VARIANTS=4 integer, the DELIVERY_CHANNEL_CASES list that used freeform string literals instead of SESSION_TYPE_* constants, and the self-referential test_delivery_channel_cases_count meta-test whose DELIVERY_CHANNEL_CASES source was never consumed by any @pytest.mark.parametrize decorator. Adding a backend to BACKEND_REGISTRY would have failed this count test while leaving the parametrize lists in each class silently stale, creating false coverage signal. Also removes the now-unused BACKEND_REGISTRY import. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ractive check build_interactive_cmd never includes the literal "exec" token — only headless codex_exec_base commands do. The assertion was always trivially true and could not detect regressions where the wrong builder variant was used. The preceding developer_instructions= check is sufficient to verify the interactive primary channel. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Trecek
deleted the
t5-p6-a1-wp1-encode-the-session-type-x-backend-discipline-de/4044-2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create
tests/contracts/test_discipline_delivery_matrix.py— a parametrized 8-case contract test suite that encodes the session-type × backend discipline-delivery channel matrix. The test exercisesbuild_interactive_cmd,build_skill_session_cmd,build_food_truck_cmd, and_read_full_sous_chefcomposition paths to assert that the PRIMARY delivery channel is populated for each (SessionType × backend) combination, making future regressions CI-detectable. Also updatetests/contracts/AGENTS.mdwith the new file entry.Closes #4044
Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-20260626-224909-325309/.autoskillit/temp/make-plan/t5_p6_a1_wp1_discipline_delivery_matrix_plan_2026-06-26_230000.md🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary
* Step used a non-Anthropic provider; caching behavior may differ.
Token Efficiency
Model Usage Breakdown