Implementation Plan: T5-P4-A1-WP2 Eliminate Duplicated Env-Assembly Block#4138
Merged
Trecek merged 8 commits intoJun 28, 2026
Merged
Conversation
… applicable_guards, write_guard_tool_names
… env assembly through base
…env_extras for skill/food_truck
…d 12-key env assembly
… line-limit exemption
…shorten test docstring
claude.py._flag_vocabulary() returned variadic_flags={ADD_DIR,PLUGIN_DIR,TOOLS}
but VARIADIC_CLAUDE_FLAGS={ADD_DIR,TOOLS} (PLUGIN_DIR belongs in NON_VARIADIC).
Also PLUGIN_DIR, OUTPUT_FORMAT, VERBOSE, APPEND_SYSTEM_PROMPT, ALLOW_DANGEROUSLY_SKIP_PERMISSIONS
were missing from non_variadic_flags. Fix: use the canonical module-level constants.
Also truncate test_backend_builder_no_independent_copies.py docstring from 108 to
88 chars to satisfy ruff E501 (99-char limit).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…qa line Reviewer flagged "currently unused, reserved for future backend dispatch" as vague forward-looking prose per project slop conventions. Retain the noqa: F841 suppressor (mechanically required); drop the explanatory text. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…h codex.py AGENT_BACKEND_DYNACONF_ENV_VAR was set after AGENT_BACKEND_ENV_VAR in build_skill_session_cmd while codex.py sets DYNACONF first. Reorder to match, reducing cognitive friction when reading both files side-by-side. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Trecek
deleted the
t5-p4-a1-wp2-eliminate-the-25-line-duplicated-env-assembly-b/4015
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expand
_assemble_shared_env_extrasinBackendCmdBuilderBaseto produce the four env keys that are currently duplicated across all four call sites (claude skill, claude food_truck, codex skill, codex food_truck):AUTOSKILLIT_HEADLESS,AUTOSKILLIT_SESSION_TYPE,AUTOSKILLIT_APPLICABLE_GUARDS,AUTOSKILLIT_WRITE_GUARD_TOOL_NAMES. Collapseclaude.py'sbuild_skill_session_cmd/_build_skill_session_cmd_implindirection into a single method using_apply_config. Replacecodex.py's inline config unpack with_apply_config. Update existing tests that reference_build_skill_session_cmd_impland the 8-key count assertion. Add AST-based arch tests verifying the consolidation.Closes #4015
Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-20260628-015959-473386/.autoskillit/temp/make-plan/t5_p4_a1_wp2_eliminate_env_assembly_duplication_plan_2026-06-28_020600.md🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary
* Step used a non-Anthropic provider; caching behavior may differ.
Token Efficiency
Model Usage Breakdown