Skip to content

Implementation Plan: T5-P4-A8-WP2 Prove planner.yaml composes valid:true under codex backend#4139

Merged
Trecek merged 8 commits into
developfrom
t5-p4-a8-wp2-prove-that-planner-yaml-composes-valid-true-und/4026
Jun 28, 2026
Merged

Implementation Plan: T5-P4-A8-WP2 Prove planner.yaml composes valid:true under codex backend#4139
Trecek merged 8 commits into
developfrom
t5-p4-a8-wp2-prove-that-planner-yaml-composes-valid-true-und/4026

Conversation

@Trecek

@Trecek Trecek commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Add a dedicated recipe validation test proving planner.yaml composes valid=True under the codex backend capability override set (backend_supports_git_write=false), and add a TestCodexSmokeRecipeComposition class with 5 gated smoke tests validating recipe composition, session diagnostics, and session locator resolution for the codex backend.

Closes #4026

Implementation Plan

Plan file: /home/talon/projects/autoskillit-runs/impl-20260628-033104-213088/.autoskillit/temp/make-plan/t5_p4_a8_wp2_planner_codex_valid_plan_2026-06-28_035000.md

🤖 Generated with Claude Code via AutoSkillit

Token Usage Summary

Step Model count uncached output cache_read peak_ctx turns cache_write time
plan* opus[1m] 1 3.8k 15.5k 2.0M 118.8k 52 119.0k 15m 2s
verify* sonnet 1 108 11.2k 626.0k 58.1k 34 39.7k 5m 12s
implement* MiniMax-M3 1 80.6k 10.6k 1.9M 0 66 0 4m 17s
fix* sonnet 1 198 7.0k 1.3M 68.8k 52 50.3k 4m 12s
audit_impl* sonnet 1 489 10.9k 203.2k 43.3k 15 36.4k 5m 57s
prepare_pr* MiniMax-M3 1 43.4k 2.6k 325.6k 0 19 0 55s
compose_pr* MiniMax-M3 1 36.5k 1.8k 141.0k 0 12 0 46s
review_pr* sonnet 1 166 58.5k 1.4M 107.0k 49 89.6k 16m 15s
resolve_review* sonnet 1 285 21.4k 2.7M 98.2k 84 80.4k 8m 11s
Total 165.5k 139.6k 10.5M 118.8k 415.5k 1h 0m

* Step used a non-Anthropic provider; caching behavior may differ.

Token Efficiency

Step LoC Changed cache_read/LoC cache_write/LoC output/LoC
plan 0
verify 0
implement 238 7966.1 0.0 44.7
fix 3 427715.7 16762.0 2343.3
audit_impl 0
prepare_pr 0
compose_pr 0
review_pr 0
resolve_review 35 76336.9 2298.4 611.8
Total 276 38134.4 1505.3 505.7

Model Usage Breakdown

Model steps uncached output cache_read cache_write time
opus[1m] 1 3.8k 15.5k 2.0M 119.0k 15m 2s
sonnet 5 1.2k 109.0k 6.2M 296.4k 39m 49s
MiniMax-M3 3 160.5k 15.0k 2.4M 0 5m 58s

Trecek and others added 8 commits June 28, 2026 03:54
Add a dedicated recipe validation test proving planner.yaml composes
valid=True under the codex backend capability override set
(backend_supports_git_write=false). The test exercises load_and_validate
directly with the backend_name and ingredient_overrides kwargs to
prove planner's recipe composition is codex-compatible independent
of the parametric matrix coverage in test_bundled_recipes_dispatch_ready.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Add 5 gated smoke tests validating recipe composition, session
diagnostics, and session locator resolution under the codex backend:

- test_open_kitchen_implementation_valid
- test_open_kitchen_planner_valid
- test_reduced_codex_smoke_pipeline_no_refusals
- test_session_diagnostics_field_completeness
- test_composite_locator_resolves_codex_session

Tests share a single codex_session fixture for the codex exec invocation,
use a _FakeLocator that returns the captured rollout path for
flush_session_log, and inject a stub backend into BACKEND_REGISTRY via
monkeypatch for the composite locator test.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
test_smoke_codex.py imports load_and_validate from autoskillit.recipe to
validate recipe composition for the codex backend. Add it to the file-level
allowlists in _TEST_LAYER_ALLOWLIST and LAYER_CASCADE_CONSERVATIVE.
@Trecek Trecek added this pull request to the merge queue Jun 28, 2026
Merged via the queue into develop with commit 749d9ca Jun 28, 2026
3 checks passed
@Trecek Trecek deleted the t5-p4-a8-wp2-prove-that-planner-yaml-composes-valid-true-und/4026 branch June 28, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant